Preserve auditd.log.record_type #10829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than renaming `auditd.log.record_type` to `event.action` and silently failing if `event.action` was pre-existing, set `event.action` with a copy of `auditd.log.record_type` if `event.type` is emtpy. This will preserve `auditd.log.record_type` if `event.type` is empty. Also, since the mappings are name instead of number based, fallback to `auditd.log.SYSCALL` to gather syscall ecs mappings if `auditd.log.syscall` fails.
nicholasberlin
added
bugfix
andrewkroh
added
Integration:auditd
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
/test |
💚 Build Succeeded
History
|
|
andrewkroh
approved these changes
Aug 22, 2024
| "a2": "242", | ||
| "a3": "180", | ||
| "items": "2", | ||
| "key": "delete\"\u001dARCH=x86_64", |
There was a problem hiding this comment.
That looks wrong. But it's unrelated to this PR.
|
Package auditd - 3.20.1 containing this change is available at https://epr.elastic.co/search?package=auditd |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
* Preserve auditd.log.record_type Rather than renaming `auditd.log.record_type` to `event.action` and silently failing if `event.action` was pre-existing, set `event.action` with a copy of `auditd.log.record_type` if `event.type` is emtpy. This will preserve `auditd.log.record_type` if `event.type` is empty.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
* Preserve auditd.log.record_type Rather than renaming `auditd.log.record_type` to `event.action` and silently failing if `event.action` was pre-existing, set `event.action` with a copy of `auditd.log.record_type` if `event.type` is emtpy. This will preserve `auditd.log.record_type` if `event.type` is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Preserve auditd.log.record_type
Rather than renaming
auditd.log.record_typetoevent.actionand silently failing ifevent.actionwas pre-existing, setevent.actionwith a copy ofauditd.log.record_typeifevent.typeis emtpy. This will preserveauditd.log.record_typeifevent.typeis empty.Also, since the mappings are name instead of number based, fallback to<-- This needs more workauditd.log.SYSCALLto gather syscall ecs mappings ifauditd.log.syscallfails.Checklist
I have verified that all data streams collect metrics or logs.changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.Related issues