-
Notifications
You must be signed in to change notification settings - Fork 474
[k8s Integratiion] Adding container.id as filter of Cluster Overview and removing median filter occurencies #10893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
container_logs |
142857.14 | 111111.11 | -31746.03 (-22.22%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
💚 Build Succeeded
History
|
Why is this @gizas? |
In all of the instances where median was used was a mistake, either needed to be last value or average and we aligned it with the other fields of the visualisations. Seems that because the first choice of filter is median (when someone creates a visualisation) this was left by mistake. Additionally, after a relevant slack thread we were pointed out that average provided better results for a customer of ours so we made the decision to prefer average. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I always thought that median was the best one to use since it does not get affected by outliers as much as average, but I trust your judgement. Could you just link the slack thread? For future reference, it might help.
Package kubernetes - 1.66.4 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
…and removing median filter occurencies (elastic#10893) * adding container.id as filter and removing median as filter
…and removing median filter occurencies (elastic#10893) * adding container.id as filter and removing median as filter
Proposed commit message
Cluster Overview Dashboard
in order to use the container.id filterAdditionally we removed all median functions from or visualisations and replaced them either with Average or Last value
The updated dashboards where the median has been removed are:
Checklist
changelog.yml
file.How to test this PR locally
kind create cluster
elastic-package stack up -d -v --version=8.15.0
in order to spin the ES locallydocker network connect elastic-package-stack_default kind-control-plane
to connect the networks of the ES and your k8s nodeRelated issues
Screenshots
From Cluster Overview:
From Cronjobs: