-
Notifications
You must be signed in to change notification settings - Fork 474
wiz: fix result.evaluation to be lowercased in cloud_configuration_finding #10914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
what do you think about changing our code to turn upper case to lower case where needed? just so 3Ps can have easier time integrating |
@JordanSh I considered it, we can maybe add it as a safety net, but my concern is that this duality will cause more headaches to the users. While we can update our code everywhere where we rely on the |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
cloud_configuration_finding |
3636.36 | 2976.19 | -660.17 (-18.15%) | 💔 |
issue |
3484.32 | 2053.39 | -1430.93 (-41.07%) | 💔 |
To see the full report comment with /test benchmark fullreport
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, cc @animehart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the relevant field here existed prior to this change, but is not an ECS field. I do not see any discussion about introduction on a non-ECS field in the original change. Is there background for that?
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@efd6 the field |
💚 Build Succeeded
History
|
|
Package wiz - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=wiz |
…nding (elastic#10914) * fix result.evaluation to be lowercased * add PR link to the changelog * Update packages/wiz/changelog.yml Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co> --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
…nding (elastic#10914) * fix result.evaluation to be lowercased * add PR link to the changelog * Update packages/wiz/changelog.yml Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co> --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Proposed commit message
Cloud Security features in Kibana rely on the lowercase value of
result.evaluation
. Fixingcloud_configuration_finding
ingest pipeline to provide the lowercased valuesChecklist
changelog.yml
file.Author's Checklist
How to test this PR locally
see #10790
Related issues
Screenshots