Skip to content

entityanalytics_ad: format SID and GUID in canonical formats #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

entityanalytics_ad: format SID and GUID in canonical formats #10923

merged 1 commit into from
Sep 4, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 28, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:entityanalytics_ad Active Directory Entity Analytics labels Aug 28, 2024
@efd6 efd6 self-assigned this Aug 28, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review August 28, 2024 22:18
@efd6 efd6 requested a review from a team as a code owner August 28, 2024 22:18
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 merged commit e172577 into elastic:main Sep 4, 2024
4 of 5 checks passed
@elasticmachine
Copy link

Package entityanalytics_ad - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_ad

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@efd6
entityanalytics_ad: format SID and GUID in canonical formats (elastic…
8d450bd 
…#10923)
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6
entityanalytics_ad: format SID and GUID in canonical formats (elastic…
d1178db 
…#10923)
@efd6 efd6 deleted the ad_ids branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:entityanalytics_ad Active Directory Entity Analytics Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @chemamartinez