[Logstash] Add guard against missing elements in codec payload
#10938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in Logstash (elastic/logstash#16410), when configuring a codec with optional settings, the stats do not get generated, causing the data collection for codecs, and thus plugins to fail. This commit adds a guard to the retrieval of `encode` and `decode` to ensure that the CEL input does not fail when encountering this issue
andrewkroh
added
Integration:logstash
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
6134.97 | 5128.21 | -1006.76 (-16.41%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
💚 Build Succeeded
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
|
Package logstash - 2.4.11 containing this change is available at https://epr.elastic.co/search?package=logstash |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
Due to a bug in Logstash (elastic/logstash#16410), when configuring a codec with optional settings, the stats do not get generated, causing the data collection for codecs, and thus plugins to fail. This commit adds a guard to the retrieval of `encode` and `decode` to ensure that the CEL input does not fail when encountering this issue
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
Due to a bug in Logstash (elastic/logstash#16410), when configuring a codec with optional settings, the stats do not get generated, causing the data collection for codecs, and thus plugins to fail. This commit adds a guard to the retrieval of `encode` and `decode` to ensure that the CEL input does not fail when encountering this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add guard against missing elements in
codecpayloadDue to a bug in Logstash (elastic/logstash#16410), when configuring a codec with optional settings, the stats do not get generated, causing the data collection for codecs, and thus plugins to fail.
This commit adds a guard to the retrieval of
encodeanddecodeto ensure that the CEL input does not fail when encountering this issue.Checklist
changelog.ymlfile.How to test this PR locally
Setup Logstash Integration to point to a working Logstash instance, the Logstash pipeline should include a codec that is configured with an optional parameter, eg
Navigate to the
Pipeline Details Overviewpage, and verify that there is data for this pipeline. There should be entries in theinputandcodecsections of the page.Related issues
elastic/logstash#16410