Skip to content

Update security rules 0.13.0 fix #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 15, 2021
Merged

Update security rules 0.13.0 fix #1127

merged 9 commits into from
Jun 15, 2021

Conversation

rw-access
Copy link
Contributor

@rw-access rw-access commented Jun 15, 2021

What does this PR do?

Adds a few changes missed in #1126

Checklist

See #1126

Screenshot again
Screen Shot 2021-06-15 at 3 42 25 PM

@rw-access rw-access requested a review from brokensound77 June 15, 2021 21:29
Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these changes need to be added to the package generation in detection-rules or were these just one-offs for the base 7.13.0 package

@rw-access
Copy link
Contributor Author

Do these changes need to be added to the package generation in detection-rules or were these just one-offs for the base 7.13.0 package

detection-rules needs to be updated, we can get that next

Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the staging test reflects as expected

@elasticmachine
Copy link

elasticmachine commented Jun 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1127 updated

  • Start Time: 2021-06-15T21:33:35.613+0000

  • Duration: 25 min 23 sec

  • Commit: 1b495a4

Trends 🧪

Image of Build Times

@rw-access rw-access merged commit 4b95133 into elastic:master Jun 15, 2021
@rw-access rw-access deleted the update-security-rules-0.13.0-fix branch June 15, 2021 21:59
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.13.0"
Copy link
Contributor

@mtojek mtojek Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rw-access Both changelog entries refer to the same version number. I suppose you forgot to bump up the version to 0.13.1?

EDIT:

improvement of semantic validation opened here: elastic/package-spec#189

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to burn a version so quickly and it was more like an amendment to the previous PR before it was pulled into package storage.

so I guess I should've changed the previous entry instead? but then which PR would I use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you already released 0.13.0 to the package-storage (I see that it's in production), then it's natural to raise the version to 0.13.1.

Copy link
Contributor Author

@rw-access rw-access Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is the one that was released as 0.13.0.
the changes in #1126 never left the integrations repo, until this one was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants