-
Notifications
You must be signed in to change notification settings - Fork 474
Update security rules 0.13.0 fix #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security rules 0.13.0 fix #1127
Conversation
…ntegrations into update-security-rules-0.13.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these changes need to be added to the package generation in detection-rules or were these just one-offs for the base 7.13.0 package
detection-rules needs to be updated, we can get that next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the staging test reflects as expected
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "0.13.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rw-access Both changelog entries refer to the same version
number. I suppose you forgot to bump up the version to 0.13.1
?
EDIT:
improvement of semantic validation opened here: elastic/package-spec#189
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to burn a version so quickly and it was more like an amendment to the previous PR before it was pulled into package storage.
so I guess I should've changed the previous entry instead? but then which PR would I use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you already released 0.13.0 to the package-storage (I see that it's in production), then it's natural to raise the version to 0.13.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is the one that was released as 0.13.0.
the changes in #1126 never left the integrations repo, until this one was merged
What does this PR do?
Adds a few changes missed in #1126
Checklist
See #1126
Screenshot again
