[Cloud Security] Updating the CSPM integration with deployment_mode and secrets #11271
Conversation
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
the
Integration:cloud_security_posture
seanrathier
force-pushed
the
10847-update-cspm-deployment-mode
branch
from
cb06892 to
01fbfe3
Compare
💚 Build Succeeded
History
|
|
andrewkroh
added
the
Team:Cloud Security
seanrathier
added
the
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| @@ -113,6 +116,7 @@ streams: | |||
| multi: false | |||
| required: false | |||
| show_user: true | |||
| secret: false | |||
There was a problem hiding this comment.
Should secret access key be true? Security concern regards of exposing secret access keys
There was a problem hiding this comment.
The lint for the integration identified these fields as needing the secret attributes, likely because they have the name access_key and session_key.
Since we already have other fields with the secret attribute set to true, I assumed these were not meant to be masked like a password.
There was a problem hiding this comment.
okay got it! Thanks!
| @@ -55,6 +56,7 @@ streams: | |||
| multi: false | |||
| required: false | |||
| show_user: true | |||
There was a problem hiding this comment.
Should secret access key be true? We don't want to expose secret?
| @@ -100,6 +102,7 @@ streams: | |||
| multi: false | |||
| required: false | |||
| show_user: true | |||
| secret: false | |||
There was a problem hiding this comment.
Should shared credentials file secret be true?
There was a problem hiding this comment.
| @@ -42,6 +42,7 @@ streams: | |||
| multi: false | |||
| required: false | |||
| show_user: true | |||
| secret: false | |||
There was a problem hiding this comment.
Any security concern regards adding secret as false?
There was a problem hiding this comment.
Omolola-Akinleye
dismissed
their stale review
I missed secrets change and want to address security concerns
|
Package cloud_security_posture - 1.11.0-preview10 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
|
Package cloud_security_posture - 1.11.0 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.11.0/ |
…nd secrets (elastic#11271) * Updating the CSPM integration with deployment_mode and secrets * buming version * changelog
…nd secrets (elastic#11271) * Updating the CSPM integration with deployment_mode and secrets * buming version * changelog
Proposed commit message
We added
deployment_modesto the CSPM integration and thesecretattribute for the inputs that the linting thought should have that set.Checklist
changelog.ymlfile.How to test this PR locally
Related issues