Skip to content

Release aws package with related.entity (and add missing data) #11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2024
Merged

Release aws package with related.entity (and add missing data) #11397

merged 2 commits into from
Oct 15, 2024

Conversation

romulets
Copy link
Member

@romulets romulets commented Oct 11, 2024 •
edited
Loading

Release aws package (2.26.0) with the new related.entity field

Shipping together the addition of the field values to related.entity:

  • json.userIdentity.accessKeyId
  • json.requestParameters.serialNumber
  • json.responseElements.user.userId
  • json.responseElements.serialNumber

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@romulets romulets added the enhancement New feature or request label Oct 11, 2024
@romulets romulets self-assigned this Oct 11, 2024
@romulets romulets requested review from a team as code owners October 11, 2024 08:40
@andrewkroh andrewkroh added Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Oct 11, 2024
@efd6 efd6 mentioned this pull request Oct 13, 2024
Merged
4 tasks
@romulets romulets force-pushed the release-related-entity branch from b187f7a to 8041885 Compare October 14, 2024 07:56
@romulets romulets enabled auto-merge (squash) October 14, 2024 08:00
@efd6
Copy link
Contributor

efd6 commented Oct 14, 2024

/test

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
28.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @romulets

@romulets romulets disabled auto-merge October 14, 2024 12:59
@romulets romulets enabled auto-merge (squash) October 14, 2024 13:00
gpop63
gpop63 reviewed Oct 14, 2024
View reviewed changes
@romulets romulets requested a review from gpop63 October 14, 2024 14:27
agithomas
agithomas approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romulets romulets merged commit 9e94e8f into elastic:main Oct 15, 2024
5 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package aws - 2.26.0 containing this change is available at https://epr.elastic.co/search?package=aws

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@romulets
Release aws package with related.entity (and add missing data) (ela…
8a7d7ff 
…stic#11397)

* Release aws package with  (and add missing data)

* Update changelog PR link
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@romulets
Release aws package with related.entity (and add missing data) (ela…
5b04488 
…stic#11397)

* Release aws package with  (and add missing data)

* Update changelog PR link
@romulets romulets deleted the release-related-entity branch February 7, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@efd6 efd6 efd6 approved these changes

@gpop63 gpop63 gpop63 approved these changes

@agithomas agithomas agithomas approved these changes

@constanca-m constanca-m constanca-m approved these changes

Assignees

@romulets romulets

Labels
enhancement New feature or request Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@romulets @efd6 @elasticmachine @andrewkroh @kaiyan-sheng @gpop63 @agithomas @constanca-m