Skip to content

[Cloud Security] lowercase host.name for cloud_secrity_posture #11437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[Cloud Security] lowercase host.name for cloud_secrity_posture #11437

merged 3 commits into from
Oct 17, 2024

Conversation

maxcold
Copy link
Contributor

@maxcold maxcold commented Oct 16, 2024

Proposed commit message

According to ECS it's recommended that host.name is lowercased. Adding lowercase processor for both misconfiguration and vulnerability ingest pipeline

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

run pipeline tests

elastic-package test pipeline --data-streams vulnerabilities && elastic-package test pipeline --data-streams findings

Related issues

Screenshots

@maxcold maxcold added enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Integration:cloud_security_posture Security Posture Management labels Oct 16, 2024
@maxcold maxcold requested a review from a team as a code owner October 16, 2024 14:57
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 16, 2024

🚀 Benchmarks report

Package cloud_security_posture 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
vulnerabilities 200000 166666.67 -33333.33 (-16.67%) 💔

To see the full report comment with /test benchmark fullreport

@maxcold maxcold requested a review from moukoublen October 16, 2024 15:33
Copy link
Member

@kubasobon kubasobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@maxcold maxcold enabled auto-merge (squash) October 17, 2024 11:34
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

@maxcold maxcold merged commit 1c70a9d into elastic:main Oct 17, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package cloud_security_posture - 1.11.0-preview13 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@maxcold maxcold deleted the csp-lowercase-host-name branch October 18, 2024 14:46
@elastic-vault-github-plugin-prod

Package cloud_security_posture - 1.11.0 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.11.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…ic#11437)

* lowercase host.name for cloud_secrity_posture

* add PR link to changelog
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…ic#11437)

* lowercase host.name for cloud_secrity_posture

* add PR link to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants