Skip to content

wiz: fix missing score handling and retain cloud_configuration_rule_description #11489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 23, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request bugfix Pull request that fixes a bug issue Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Oct 23, 2024
@efd6 efd6 self-assigned this Oct 23, 2024
Comment on lines +2 to +9
- version: "1.8.2"
changes:
- description: Relax requirement for vulnerability score to be present.
type: bugfix
link: https://github.com/elastic/integrations/pull/11489
- description: Retain `cloudConfigurationRuleDescription` from `sourceRule`.
type: enhancement
link: https://github.com/elastic/integrations/pull/11489
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately required to be a patch bump despite being an enhancement due to constraints that exist due to the use of preview marks in the 1.9 version of the integration published in main.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

Comment on lines +106 to +107
- name: cloud_configuration_rule_description
type: keyword
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be a match_only_text, but the other fields here, control_description and resolution_recommendation should also, so maintaining alignment and not breaking things by fixing those fields.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #17470 failed 77afc4cda6ccccd4043211f8db5ffc5126df7d58

cc @efd6

@efd6 efd6 marked this pull request as ready for review October 23, 2024 01:46
@efd6 efd6 requested a review from a team as a code owner October 23, 2024 01:46
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 merged commit e696b38 into elastic:backport-wiz-1.8 Oct 23, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package wiz - 1.8.2 containing this change is available at https://epr.elastic.co/search?package=wiz

@efd6 efd6 deleted the s5298-wiz-1.8 branch February 5, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants