AWS ELB add support for ALPN policy details in NLB logs #11590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
the
Team:Obs-InfraObs
shmsr
reviewed
Oct 30, 2024
shmsr
approved these changes
Oct 30, 2024
gpop63
approved these changes
Oct 30, 2024
kcreddy
approved these changes
Oct 31, 2024
|
@elastic/obs-ds-hosted-services , could you please review the PR? |
zmoog
approved these changes
Nov 5, 2024
Comment on lines
+132
to
+133
| description: > | ||
| The value of the application_layer_protocol_negotiation extension in the client hello message. This value is URL-encoded. |
There was a problem hiding this comment.
Why did we keep the alpn_client_preference_list in its source form and not parse it as a list? Do we expect users to need it in its pristine form?
There was a problem hiding this comment.
In this is needed, we can do something like this. Keeping it for further reference / enhancement
- script:
lang: painless
source: >-
if (ctx?.aws?.elb?.alpn_client_preference_list != null && ctx?.aws?.elb?.alpn_client_preference_list != '-' && !ctx?.aws?.elb?.alpn_client_preference_list.trim().isEmpty()) {
String cleanedList = ctx.aws.elb.alpn_client_preference_list;
// Use regex to split by comma
String[] protocols = /,/.split(cleanedList);
ArrayList filteredProtocols = new ArrayList();
for (String protocol : protocols) {
def protocol_temp = /[\\"]/.matcher(protocol).replaceAll("");
if (!protocol_temp.trim().isEmpty()) {
filteredProtocols.add(protocol_temp.trim());
}
}
ctx.aws.elb.alpn_client_preference_list = filteredProtocols;
} else {
// Set to an empty array if the conditions are not met
ctx.aws.elb.alpn_client_preference_list = [];
}
|
/test |
kaiyan-sheng
reviewed
Nov 5, 2024
packages/aws/data_stream/elb_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
…e/default.yml Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
💚 Build Succeeded
History
cc @agithomas |
|
|
Package aws - 2.31.2 containing this change is available at https://epr.elastic.co/search?package=aws |
7 tasks
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
* AWS ELB add support for ALPN policy details in NLB logs
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
* AWS ELB add support for ALPN policy details in NLB logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add support for extracting ALPN policy related details from NLB access log data.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-package build && elastic-package stack up -v -d --services package-registryRelated issues
Screenshots