Skip to content

[azure] Fix error and improve clarity in Storage Account docs #11660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Nov 7, 2024

Proposed commit message

Fix an error and contradiction about how the azure-eventhub input uses the storage account to create containers to store the event hub checkpoint information.

The error was in this sentence:

The Elastic Agent can use one Storage account container for all integrations.

It should have been:

The Elastic Agent can use one Storage account for all integrations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • [ ] I have verified that Kibana version constraints are current according to guidelines.
  • [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

CleanShot 2024-11-07 at 09 36 35@2x

@zmoog zmoog self-assigned this Nov 7, 2024
@zmoog zmoog added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Nov 7, 2024
@zmoog zmoog marked this pull request as ready for review November 7, 2024 08:49
@zmoog zmoog requested review from a team as code owners November 7, 2024 08:49
@zmoog zmoog requested a review from alaudazzi November 7, 2024 08:49
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package azure 👍(10) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
application_gateway 2793.3 2118.64 -674.66 (-24.15%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @zmoog

Copy link

@MichaelKatsoulis MichaelKatsoulis self-requested a review November 7, 2024 09:31
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- assuming event hub capitalization is correctly used in this case.

@zmoog zmoog merged commit 01fbb82 into elastic:main Nov 8, 2024
5 checks passed
@zmoog zmoog deleted the zmoog/clarify-storage-account-documentation-in-the-azure-logs-integration branch November 8, 2024 08:13
@elastic-vault-github-plugin-prod

Package azure - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=azure

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…c#11660)

Fix an error and contradiction about how the `azure-eventhub` input uses the storage account to create containers to store the event hub checkpoint information.

The error was in this sentence:

> The Elastic Agent can use one Storage account **container** for all integrations.

It should have been:

> The Elastic Agent can use one Storage account for all integrations.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…c#11660)

Fix an error and contradiction about how the `azure-eventhub` input uses the storage account to create containers to store the event hub checkpoint information.

The error was in this sentence:

> The Elastic Agent can use one Storage account **container** for all integrations.

It should have been:

> The Elastic Agent can use one Storage account for all integrations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:azure Azure Logs Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Clarify storage account documentation in the Azure Logs integration
4 participants