Skip to content

sublime_security: fix water mark use #11683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 10, 2024

Proposed commit message

The current implementation never makes use of the water mark. So duplicates will continue to occur. Fix this.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:sublime_security Sublime Security labels Nov 10, 2024
@efd6 efd6 self-assigned this Nov 10, 2024
The current implementation never makes use of the water mark. So duplicates
will continue to occur. Fix this.
@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

Copy link

@efd6 efd6 marked this pull request as ready for review November 10, 2024 22:29
@efd6 efd6 requested a review from a team as a code owner November 10, 2024 22:29
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@efd6 efd6 merged commit 2d670cc into elastic:main Nov 11, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package sublime_security - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=sublime_security

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
The current implementation never makes use of the water mark. So duplicates
will continue to occur. Fix this.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
The current implementation never makes use of the water mark. So duplicates
will continue to occur. Fix this.
@efd6 efd6 deleted the 11623-sublime_security branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:sublime_security Sublime Security Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sublime Security]: Duplicate Data Ingestion when using API
3 participants