Skip to content

[cisco_ios] Fix FQDN parsing #11731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Nov 18, 2024
Merged

[cisco_ios] Fix FQDN parsing #11731

merged 0 commits into from
Nov 18, 2024

Conversation

aleksmaus
Copy link
Contributor

Proposed commit message

[cisco_ios] Fix FQDN parsing

Added '.' dot character to the CISCO_HOSTNAME allowed characters and increased length to 255 characters total, since this is the max length of FQDN.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@aleksmaus aleksmaus added Integration:cisco_ios Cisco IOS bugfix Pull request that fixes a bug issue labels Nov 13, 2024
@aleksmaus aleksmaus self-assigned this Nov 13, 2024
@aleksmaus aleksmaus requested a review from a team as a code owner November 13, 2024 20:54
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @aleksmaus

@andrewkroh andrewkroh added the Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Nov 18, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@aleksmaus aleksmaus merged commit 70b41e1 into elastic:main Nov 18, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package cisco_ios - 1.28.1 containing this change is available at https://epr.elastic.co/package/cisco_ios/1.28.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* [cisco_ios] Fix FQDN parsing

* Update changelog PR number
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* [cisco_ios] Fix FQDN parsing

* Update changelog PR number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CISCO_IOS]: Custom grok pattern CISCO_HOSTNAME cannot handle FQDNs
4 participants