Skip to content

Removed technical preview language #11761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Jan 22, 2025
Merged

Removed technical preview language #11761

merged 0 commits into from
Jan 22, 2025

Conversation

flexitrev
Copy link
Contributor

Documentation

Proposed commit message

Updated documentation to remove technical preview label on Agent based monitoring

-->

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@flexitrev flexitrev requested a review from a team as a code owner November 18, 2024 17:10
@flexitrev flexitrev added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Nov 18, 2024
@flexitrev flexitrev requested a review from robbavey November 18, 2024 17:10
@andrewkroh andrewkroh added Integration:logstash Logstash Team:Stack Monitoring Stack Monitoring team [elastic/stack-monitoring] labels Nov 18, 2024
consulthys
consulthys reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos to fix

consulthys
consulthys reviewed Nov 19, 2024
View reviewed changes
consulthys
consulthys approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

robbavey
robbavey requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on consistency and wording

@flexitrev flexitrev requested a review from robbavey December 18, 2024 18:15
robbavey
robbavey approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flexitrev
Copy link
Contributor Author

@consulthys any tips on getting ci to work?

@botelastic
Copy link

botelastic bot commented Jan 17, 2025

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 17, 2025
@flexitrev
Copy link
Contributor Author

Refreshing to get away from stale label

@botelastic botelastic bot removed the Stalled label Jan 17, 2025
@robbavey
Copy link
Member

The build is failing because your template README file has different content than the generated content - try running elastic-package build locally, and reup the generated content

@andrewkroh andrewkroh added the enhancement New feature or request label Jan 21, 2025
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

robbavey
robbavey reviewed Jan 22, 2025
View reviewed changes
packages/logstash/_dev/build/docs/README.md
@@ -37,7 +37,279 @@ Logstash metric related data streams works with Logstash 7.3.0 and later.

### Node Stats

{{event "node_stats"}}
An example event for `node_stats` looks as following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev version of readme.md should have the macro for event objects such as node_stats to be expanded automatically

@flexitrev flexitrev merged commit f170c58 into main Jan 22, 2025
5 checks passed
@flexitrev flexitrev deleted the logstash-integration_metricsGA branch January 22, 2025 20:38
@elastic-vault-github-plugin-prod
Copy link

Package logstash - 2.4.12 containing this change is available at https://epr.elastic.co/package/logstash/2.4.12/

@robbavey
Copy link
Member

@flexitrev We will need a follow up PR here, to fix this issue - the README.md file in `_dev/build/docs' should not contain the raw events, but should use the macros/variables instead - eg https://github.com/elastic/integrations/blob/main/packages/elasticsearch/_dev/build/docs/README.md

@flexitrev flexitrev mentioned this pull request Jan 24, 2025
Closed
@flexitrev
Copy link
Contributor Author

#12461 follow up to fix README

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@flexitrev @robbavey
Removed technical preview language (elastic#11761)
ac717ac 
* Removed technical preview language

Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@flexitrev @robbavey
Removed technical preview language (elastic#11761)
060e30c 
* Removed technical preview language

Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

@consulthys consulthys consulthys approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:logstash Logstash Team:Stack Monitoring Stack Monitoring team [elastic/stack-monitoring]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flexitrev @robbavey @elasticmachine @consulthys @andrewkroh