Skip to content

[azure] Standardize the azure.platformlogs.Identity field to .identity #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Nov 19, 2024

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Nov 18, 2024

Proposed commit message

Renames the field azure.platformlogs.Identity to azure.platformlogs.identity for consistency.

Sometimes users send log categories with an azure.platformlogs.Identity to platform logs. Some documents contain azure.platformlogs.Identity as a string, while others are as an object, causing mapping exceptions.

By renaming azure.platformlogs.Identity to azure.platformlogs.identity the rest of the pipeline will take care of the string and object cases.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@zmoog zmoog changed the title [azure]sStandardize the .Identity field to .identity [azure] Standardize the azure.platform.Identity field to azure.platform.identity Nov 18, 2024
@zmoog zmoog changed the title [azure] Standardize the azure.platform.Identity field to azure.platform.identity [azure] Standardize the azure.platformlogs.Identity field to .identity Nov 18, 2024
@zmoog zmoog self-assigned this Nov 18, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 18, 2024

🚀 Benchmarks report

Package azure 👍(5) 💚(3) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
signinlogs 2439.02 1956.95 -482.07 (-19.76%) 💔
springcloudlogs 5208.33 4219.41 -988.92 (-18.99%) 💔
identity_protection 4464.29 3533.57 -930.72 (-20.85%) 💔

To see the full report comment with /test benchmark fullreport

@zmoog zmoog marked this pull request as ready for review November 18, 2024 23:47
@zmoog zmoog requested review from a team as code owners November 18, 2024 23:47
@zmoog zmoog enabled auto-merge (squash) November 18, 2024 23:57
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Nov 19, 2024
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zmoog
Copy link
Contributor Author

zmoog commented Nov 19, 2024

/test

Copy link

@zmoog zmoog merged commit 1afad95 into elastic:main Nov 19, 2024
5 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #18435 failed 5971171565341b6357ab6fce9971b97646b9caa4
  • 💔 Build #18429 failed 5971171565341b6357ab6fce9971b97646b9caa4
  • 💚 Build #18427 succeeded fc817a46aa841f7c6975a06bde52f8597bf2458d

cc @zmoog

@zmoog zmoog deleted the zmoog/azure-logs-identity branch November 19, 2024 07:26
@elastic-vault-github-plugin-prod

Package azure - 1.19.3 containing this change is available at https://epr.elastic.co/package/azure/1.19.3/

qcorporation pushed a commit that referenced this pull request Feb 3, 2025
…tity` (#11765)

Renames the field `azure.platformlogs.Identity`  to `azure.platformlogs.identity` for consistency.

Sometimes users send log categories with an `azure.platformlogs.Identity` to platform logs. Some documents contain `azure.platformlogs.Identity` as a string, while others are as an object, causing mapping exceptions. 

By renaming `azure.platformlogs.Identity` to `azure.platformlogs.identity` the rest of the pipeline will take care of the string and object cases.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…tity` (elastic#11765)

Renames the field `azure.platformlogs.Identity`  to `azure.platformlogs.identity` for consistency.

Sometimes users send log categories with an `azure.platformlogs.Identity` to platform logs. Some documents contain `azure.platformlogs.Identity` as a string, while others are as an object, causing mapping exceptions. 

By renaming `azure.platformlogs.Identity` to `azure.platformlogs.identity` the rest of the pipeline will take care of the string and object cases.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…tity` (#11765)

Renames the field `azure.platformlogs.Identity`  to `azure.platformlogs.identity` for consistency.

Sometimes users send log categories with an `azure.platformlogs.Identity` to platform logs. Some documents contain `azure.platformlogs.Identity` as a string, while others are as an object, causing mapping exceptions. 

By renaming `azure.platformlogs.Identity` to `azure.platformlogs.identity` the rest of the pipeline will take care of the string and object cases.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…tity` (elastic#11765)

Renames the field `azure.platformlogs.Identity`  to `azure.platformlogs.identity` for consistency.

Sometimes users send log categories with an `azure.platformlogs.Identity` to platform logs. Some documents contain `azure.platformlogs.Identity` as a string, while others are as an object, causing mapping exceptions. 

By renaming `azure.platformlogs.Identity` to `azure.platformlogs.identity` the rest of the pipeline will take care of the string and object cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants