-
Notifications
You must be signed in to change notification settings - Fork 474
[iptables] Add mapping for journald.custom fields #11839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
🚀 Benchmarks reportTo see the full report comment with |
SEQNUM_ID is not a "custom" field. This is built-in to journald. IMO this is an input bug that it writes it to the "journald.custom" namespace. We should fix that problem. To address the test failure, could we ship an update to the ingest pipeline that drops this specific field instead of using the flattened? The field is not particularly useful IMO and takes up a lot of space. |
Thanks, that's good to know. I've removed the seqnum fields in the ingest pipeline |
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will you please open an elastic/beats issue to track the underlying input problem that neither field should be sent through as "custom".
link: https://github.com/elastic/integrations/pull/999999 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link: https://github.com/elastic/integrations/pull/999999 | |
link: https://github.com/elastic/integrations/pull/11839 |
@@ -1,4 +1,10 @@ | |||
# newer versions go on top | |||
- version: "1.17.0" | |||
changes: | |||
- description: Remove journald seqnum fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- description: Remove journald seqnum fields | |
- description: Remove journald.custom.seqnum and journald.custom.seqnum_id which are misclassified as custom fields by the journald input. |
@mjwolf Sorry, I didn't notice that auto-merge was enabled. I did have a suggestion and one request. |
Add mappings for `journald.custom` fields, which will fix an automated system test failure.
Add mappings for `journald.custom` fields, which will fix an automated system test failure.
Fixes this error in system tests:
e.g. https://buildkite.com/elastic/integrations/builds/17669
Proposed commit message
Add mappings for
journald.custom
fields, which will fix an automated system test failure.Checklist
changelog.yml
file.I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
Run
elastic-package test system
, there should be no failuresRelated issues