Skip to content

[iptables] Add mapping for journald.custom fields #11839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Dec 6, 2024

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Nov 23, 2024

Fixes this error in system tests:

test case failed: one or more errors found in documents stored in logs-iptables.log-95566 data stream: [0] field "journald.custom.seqnum" is undefined
[1] field "journald.custom.seqnum_id" is undefined

e.g. https://buildkite.com/elastic/integrations/builds/17669

Proposed commit message

Add mappings for journald.custom fields, which will fix an automated system test failure.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Run elastic-package test system, there should be no failures

Related issues

@mjwolf mjwolf added Integration:iptables Iptables bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Nov 23, 2024
@mjwolf mjwolf requested a review from a team as a code owner November 23, 2024 00:08
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@mjwolf mjwolf enabled auto-merge (squash) November 23, 2024 00:13
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh
Copy link
Member

andrewkroh commented Nov 23, 2024

SEQNUM_ID is not a "custom" field. This is built-in to journald. IMO this is an input bug that it writes it to the "journald.custom" namespace. We should fix that problem.

To address the test failure, could we ship an update to the ingest pipeline that drops this specific field instead of using the flattened? The field is not particularly useful IMO and takes up a lot of space.

@mjwolf
Copy link
Contributor Author

mjwolf commented Nov 25, 2024

SEQNUM_ID is not a "custom" field. This is built-in to journald. IMO this is an input bug that it writes it to the "journald.custom" namespace. We should fix that problem.

To address the test failure, could we ship an update to the ingest pipeline that drops this specific field instead of using the flattened? The field is not particularly useful IMO and takes up a lot of space.

Thanks, that's good to know. I've removed the seqnum fields in the ingest pipeline

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #18628 succeeded 7046cb81f21b01036de289be5aa2953af691e5d2

Copy link

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will you please open an elastic/beats issue to track the underlying input problem that neither field should be sent through as "custom".

Comment on lines 6 to 7
link: https://github.com/elastic/integrations/pull/999999

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/999999
link: https://github.com/elastic/integrations/pull/11839

@@ -1,4 +1,10 @@
# newer versions go on top
- version: "1.17.0"
changes:
- description: Remove journald seqnum fields
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Remove journald seqnum fields
- description: Remove journald.custom.seqnum and journald.custom.seqnum_id which are misclassified as custom fields by the journald input.

@mjwolf mjwolf merged commit 8cc3f48 into elastic:main Dec 6, 2024
5 checks passed
@andrewkroh
Copy link
Member

@mjwolf Sorry, I didn't notice that auto-merge was enabled. I did have a suggestion and one request.

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Add mappings for `journald.custom` fields, which will fix an automated system test failure.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Add mappings for `journald.custom` fields, which will fix an automated system test failure.
@mjwolf mjwolf deleted the iptables-mapping branch February 5, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:iptables Iptables Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
3 participants