-
Notifications
You must be signed in to change notification settings - Fork 474
Fix broken link for Prebuilt Security Detection Rules #11929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link for Prebuilt Security Detection Rules #11929
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
@@ -1,5 +1,10 @@ | |||
# newer versions go on top | |||
# NOTE: please use pre-release versions (e.g. -beta.0) until a package is ready for production | |||
- version: 8.16.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why a version bump is being done to fix readme docs here, which will not include any rule updates. Which means the rule packages will be as good as 8.16.2
We could combine this fix in our upcoming release schedule along with rule package changes, if this is not a critical fix that needs be published right away.
We have a release scheduled on Dec 9 for 8.16.3 version, along with other supported versions, which can accommodate this change for 8.16.3 and future versions.
cc @Mikaayenson
Apologies, this was missed in the last release train, we ran into issues of packages, which made me err and forget we had to piggy back this change. The change will fix the broken documentation, here where there will be no updates to the package. ![]() My only suggestion would be make this beta 8.17.2-beta.1 and we will GA it together with the next package updates in Jan 2025. the PR can be closed. I am just suggesting a beta package as opposed to a GA one. Will that work @alaudazzi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the beta change to GA this along with packages updates in Jan 2025.
💚 Build Succeeded
History
cc @alaudazzi |
|
Package security_detection_engine - 8.17.2-beta.1 containing this change is available at https://epr.elastic.co/package/security_detection_engine/8.17.2-beta.1/ |
This PR fixes a broken link to https://www.elastic.co/guide/en/security/master/rules-ui-management.html#import-export-rules-ui
Relates https://github.com/elastic/integration-docs/issues/586