Skip to content

[integrations][GitHub] - Addressed some missing documentation issues and fixed timestamp value in sample logs #11932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Nov 30, 2024
Merged

[integrations][GitHub] - Addressed some missing documentation issues and fixed timestamp value in sample logs #11932

merged 0 commits into from
Nov 30, 2024

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Bug

Proposed commit message

Addressed some missing documentation issues and fixed timestamp value in sample logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG requested a review from a team as a code owner November 30, 2024 05:41
@ShourieG ShourieG requested a review from kcreddy November 30, 2024 05:42
@ShourieG ShourieG self-assigned this Nov 30, 2024
@ShourieG ShourieG added bugfix Pull request that fixes a bug issue integration Label used for meta issues tracking each integration Integration:github GitHub Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 30, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG mentioned this pull request Nov 30, 2024
Merged
5 tasks
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ShourieG ShourieG merged commit e6b0654 into elastic:main Nov 30, 2024
5 checks passed
@ShourieG ShourieG deleted the github/bugfix branch November 30, 2024 09:12
@elastic-vault-github-plugin-prod
Copy link

Package github - 2.1.1 containing this change is available at https://epr.elastic.co/package/github/2.1.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@ShourieG
[integrations][GitHub] - Addressed some missing documentation issues …
88983f7 
…and fixed timestamp value in sample logs (elastic#11932)
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@ShourieG
[integrations][GitHub] - Addressed some missing documentation issues …
b835690 
…and fixed timestamp value in sample logs (elastic#11932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@ShourieG ShourieG

Labels
bugfix Pull request that fixes a bug issue Integration:github GitHub integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @kcreddy