Skip to content

proofpoint_on_demand.mail: Fix script processor handling sm field #12011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Dec 6, 2024

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Dec 5, 2024

Proposed commit message

Fix null reference in script processor script_remove_unwanted_characters.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Run pipeline tests:
eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v --data-streams=mail

Before:

[0] unexpected pipeline error: [Processor script with tag script_remove_unwanted_characters in pipeline default-1733400250436322000 failed with message: cannot access method/field [to] from a null def reference]


╭──────────────────────┬─────────────┬───────────┬──────────────────────────────────────────┬─────────────────────────────────────────────────────────────────────────────┬──────────────╮
│ PACKAGE              │ DATA STREAM │ TEST TYPE │ TEST NAME                                │ RESULT                                                                      │ TIME ELAPSED │
├──────────────────────┼─────────────┼───────────┼──────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────────┼──────────────┤
│ proofpoint_on_demand │ mail        │ pipeline  │ (ingest pipeline warnings test-mail.log) │ PASS                                                                        │ 328.354709ms │
│ proofpoint_on_demand │ mail        │ pipeline  │ test-mail.log                            │ FAIL: test case failed: one or more problems with fields found in documents │ 699.680708ms │
╰──────────────────────┴─────────────┴───────────┴──────────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────────┴──────────────╯
--- Test results for package: proofpoint_on_demand - END   ---
Done
Error: one or more test cases failed

Now:

--- Test results for package: proofpoint_on_demand - START ---
╭──────────────────────┬─────────────┬───────────┬──────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE              │ DATA STREAM │ TEST TYPE │ TEST NAME                                │ RESULT │ TIME ELAPSED │
├──────────────────────┼─────────────┼───────────┼──────────────────────────────────────────┼────────┼──────────────┤
│ proofpoint_on_demand │ mail        │ pipeline  │ (ingest pipeline warnings test-mail.log) │ PASS   │ 328.461625ms │
│ proofpoint_on_demand │ mail        │ pipeline  │ test-mail.log                            │ PASS   │ 158.642625ms │
╰──────────────────────┴─────────────┴───────────┴──────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: proofpoint_on_demand - END   ---
Done

@kcreddy kcreddy self-assigned this Dec 5, 2024
@kcreddy kcreddy added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:proofpoint_on_demand Proofpoint On Demand labels Dec 5, 2024
@kcreddy kcreddy marked this pull request as ready for review December 5, 2024 12:16
@kcreddy kcreddy requested a review from a team as a code owner December 5, 2024 12:16
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kcreddy

Copy link

@kcreddy kcreddy merged commit 9976a84 into elastic:main Dec 6, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package proofpoint_on_demand - 1.0.2 containing this change is available at https://epr.elastic.co/package/proofpoint_on_demand/1.0.2/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…lastic#12011)

Fix null reference in script processor `script_remove_unwanted_characters`
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…lastic#12011)

Fix null reference in script processor `script_remove_unwanted_characters`
@kcreddy kcreddy deleted the proofpoint_mail branch February 7, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:proofpoint_on_demand Proofpoint On Demand Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants