Skip to content

ssi_all: fix string literal syntax in painless scripts #12047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Dec 11, 2024
Merged

ssi_all: fix string literal syntax in painless scripts #12047

merged 0 commits into from
Dec 11, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 10, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:symantec_endpoint Symantec Endpoint Protection Integration:google_workspace Google Workspace Integration:cylance CylanceProtect Logs (Deprecated) Integration:jamf_compliance_reporter Jamf Compliance Reporter Integration:m365_defender Microsoft Defender XDR Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI Integration:darktrace Darktrace Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:jamf_protect Jamf Protect (Partner supported) Integration:gitlab GitLab labels Dec 10, 2024
@efd6 efd6 self-assigned this Dec 10, 2024
@efd6 efd6 force-pushed the source_strings branch 2 times, most recently from 796950f to 047b315 Compare December 10, 2024 02:49
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 10, 2024 •
edited
Loading

🚀 Benchmarks report

Package cloudflare_logpush 👍(13) 💚(3) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
device_posture 6134.97 4132.23 -2002.74 (-32.64%) 💔
gateway_dns 4405.29 2680.97 -1724.32 (-39.14%) 💔

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review December 10, 2024 08:13
@efd6 efd6 requested a review from a team as a code owner December 10, 2024 08:13
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few data-streams missed that have similar problem and are owned by us:

azure.firewall_logs
m365_defender.alert
microsoft_sentinel.alert
microsoft_sentinel.event

Also, while looking at the CI system test errors, the only data-stream that is not complaining in google_workspace package is admin. It doesn't seem to have a cleanup null script at the end. We could add one.

@efd6 efd6 requested review from a team as code owners December 10, 2024 20:49
@efd6
Copy link
Contributor Author

efd6 commented Dec 10, 2024

I'm unable to reproduce the google_workspace failures locally, so I am backing them out of this change.

@efd6 efd6 removed the Integration:google_workspace Google Workspace label Dec 10, 2024
andrewkroh
andrewkroh reviewed Dec 10, 2024
View reviewed changes
packages/m365_defender/changelog.yml Outdated
@@ -1,4 +1,14 @@
# newer versions go on top
- version: "2.15.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package has two versions/changelogs for the change.

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #19329 succeeded a7385a9852bca30f927323003d5e5fc5a3284f10
  • 💚 Build #19326 succeeded 299dc57e9ad8cf8725a5a67a336df2d12fa83559
  • 💔 Build #19323 failed 527c84b4425b634fa06439ee413b232d169c675e
  • 💔 Build #19259 failed 047b315f436e4998c9d766d92750d60b5daf7fd6

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
97.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 merged commit 1677a4c into elastic:main Dec 11, 2024
5 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package azure - 1.20.1 containing this change is available at https://epr.elastic.co/package/azure/1.20.1/

@elastic-vault-github-plugin-prod
Copy link

Package cloudflare_logpush - 1.26.1 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.26.1/

@elastic-vault-github-plugin-prod
Copy link

Package cylance - 0.21.2 containing this change is available at https://epr.elastic.co/package/cylance/0.21.2/

@elastic-vault-github-plugin-prod
Copy link

Package darktrace - 1.20.1 containing this change is available at https://epr.elastic.co/package/darktrace/1.20.1/

@elastic-vault-github-plugin-prod
Copy link

Package gitlab - 1.1.1 containing this change is available at https://epr.elastic.co/package/gitlab/1.1.1/

@elastic-vault-github-plugin-prod
Copy link

Package infoblox_bloxone_ddi - 1.18.1 containing this change is available at https://epr.elastic.co/package/infoblox_bloxone_ddi/1.18.1/

@elastic-vault-github-plugin-prod
Copy link

Package jamf_compliance_reporter - 1.13.1 containing this change is available at https://epr.elastic.co/package/jamf_compliance_reporter/1.13.1/

@elastic-vault-github-plugin-prod
Copy link

Package jamf_protect - 2.6.4 containing this change is available at https://epr.elastic.co/package/jamf_protect/2.6.4/

@elastic-vault-github-plugin-prod
Copy link

Package m365_defender - 2.15.2 containing this change is available at https://epr.elastic.co/package/m365_defender/2.15.2/

@elastic-vault-github-plugin-prod
Copy link

Package microsoft_sentinel - 0.1.1 containing this change is available at https://epr.elastic.co/package/microsoft_sentinel/0.1.1/

@elastic-vault-github-plugin-prod
Copy link

Package symantec_endpoint - 2.16.3 containing this change is available at https://epr.elastic.co/package/symantec_endpoint/2.16.3/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@efd6
ssi_all: fix string literal syntax in painless scripts (elastic#12047)
394f270
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6
ssi_all: fix string literal syntax in painless scripts (elastic#12047)
c5be7fc
@efd6 efd6 deleted the source_strings branch February 5, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh left review comments

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:azure Azure Logs Integration:cloudflare_logpush Cloudflare Logpush Integration:cylance CylanceProtect Logs (Deprecated) Integration:darktrace Darktrace Integration:gitlab GitLab Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI Integration:jamf_compliance_reporter Jamf Compliance Reporter Integration:jamf_protect Jamf Protect (Partner supported) Integration:m365_defender Microsoft Defender XDR Integration:microsoft_sentinel Microsoft Sentinel Integration:symantec_endpoint Symantec Endpoint Protection Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @andrewkroh @kcreddy