cloudflare_logpush: Generically rename non-AWS S3-compatible bucket options. #12053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcreddy
added
documentation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
commented
Dec 10, 2024
| @@ -118,12 +118,12 @@ policy_templates: | |||
| description: It is a required parameter for collecting logs via the AWS S3 Bucket. | |||
| - name: cloudflare_r2 | |||
There was a problem hiding this comment.
The config option names such as cloudflare_r2 (package manifest) and cloudflare_r2_* (data-stream manifest) are untouched to avoid a breaking change.
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
magic_ids |
10309.28 | 8695.65 | -1613.63 (-15.65%) | 💔 |
workers_trace |
10101.01 | 5128.21 | -4972.8 (-49.23%) | 💔 |
casb |
6802.72 | 5494.51 | -1308.21 (-19.23%) | 💔 |
dns |
9803.92 | 8196.72 | -1607.2 (-16.39%) | 💔 |
dns_firewall |
3663 | 3086.42 | -576.58 (-15.74%) | 💔 |
firewall_event |
4405.29 | 2832.86 | -1572.43 (-35.69%) | 💔 |
gateway_dns |
4405.29 | 2710.03 | -1695.26 (-38.48%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
cc @kcreddy |
|
efd6
approved these changes
Dec 11, 2024
|
Package cloudflare_logpush - 1.26.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.26.0/ |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…ptions. (elastic#12053) - Change the UI setting name from `Cloudflare R2 Bucket Name` to `S3-Compatible Bucket Name`. - Generalise the setting's description. - Also update README to generalise the option.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…ptions. (elastic#12053) - Change the UI setting name from `Cloudflare R2 Bucket Name` to `S3-Compatible Bucket Name`. - Generalise the setting's description. - Also update README to generalise the option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Cloudflare R2 Bucket NametoS3-Compatible Bucket Name.Ref: #10733
Note
Only changes the UI for the user. The respective config option names are untouched to avoid breaking change.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots