Skip to content

[azure][graphactivitylogs] - Fixed a bug related to event.duration value mapping #12233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jan 7, 2025

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jan 6, 2025

Type of change

  • Bug

Proposed commit message

Fixed an issue where event.duration values were not properly being converted by implicit assignment due to differing on the basis of source and target datatypes. Added a convert processor to make this work properly and also fixed a naming related buf.

Note:

Some url extensions got removed because previously the parsing was incorrectly done, extensions should only occur after a '.', but the version number '.' was being incorrectly used. This is likely due to recent internal updates and not related to this change but regenerating the tests rectified this.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG requested review from a team as code owners January 6, 2025 17:08
@ShourieG ShourieG self-assigned this Jan 6, 2025
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jan 6, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added bugfix Pull request that fixes a bug issue integration Label used for meta issues tracking each integration Integration:azure Azure Logs labels Jan 6, 2025
@ShourieG ShourieG requested a review from kcreddy January 6, 2025 17:11
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

@Kavindu-Dodan Kavindu-Dodan requested a review from zmoog January 6, 2025 21:20
@@ -109,7 +109,6 @@
],
"url": {
"domain": "graph.microsoft.com",
"extension": "0/organization/a140785b-418d-4344-a4ec-8e9648919gdb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShourieG, if you ran pipeline tests on 8.13 you will continue to get this.
The bug was fixed in 8.14: elastic/elasticsearch#105689

@ShourieG ShourieG merged commit 9c13a5b into elastic:main Jan 7, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package azure - 1.20.2 containing this change is available at https://epr.elastic.co/package/azure/1.20.2/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@ShourieG ShourieG deleted the azure_graphactivity/bugfix branch February 7, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:azure Azure Logs integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants