Skip to content

[cisco_ftd] Ensure event message is saved to event.reason for IDs 101001 through 105052 #12343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jan 14, 2025
Merged

[cisco_ftd] Ensure event message is saved to event.reason for IDs 101001 through 105052 #12343

merged 0 commits into from
Jan 14, 2025

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 14, 2025

Proposed commit message

  • Events with ID 101001 through 105052 were not explicitly handled by the pipeline, which means the reason text from the event would be discarded.
  • Added a script processor to save off the message to event.reason for these events.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/cisco_ftd
elastic-package test

@taylor-swanson taylor-swanson added Integration:cisco_ftd Cisco FTD bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Jan 14, 2025
@taylor-swanson taylor-swanson self-assigned this Jan 14, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson marked this pull request as ready for review January 14, 2025 16:27
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 14, 2025 16:27
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #20393 succeeded 857957e3b915df51b3bb4d6acacafa76a7e1ea67
  • 💔 Build #20388 failed 8820017f2df33e1823b5cefe77dfd5c815f80377

cc @taylor-swanson

Copy link

@taylor-swanson taylor-swanson merged commit 0218d9c into elastic:main Jan 14, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package cisco_ftd - 3.5.0 containing this change is available at https://epr.elastic.co/package/cisco_ftd/3.5.0/

@taylor-swanson taylor-swanson deleted the fix/cisco-ftd-event-reasons branch January 14, 2025 21:19
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…001 through 105052 (elastic#12343)

- Events with ID 101001 through 105052 were not explicitly handled by the pipeline, which
means the reason text from the event would be discarded.
- Added a script processor to save off the message to event.reason for these events.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…001 through 105052 (elastic#12343)

- Events with ID 101001 through 105052 were not explicitly handled by the pipeline, which
means the reason text from the event would be discarded.
- Added a script processor to save off the message to event.reason for these events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cisco_ftd Cisco FTD Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants