Skip to content

Add external and module fields for Kafka package #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

jsoriano
Copy link
Member

What does this PR do?

  • Add external ECS fields.
  • Add module and dataset fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@jsoriano jsoriano self-assigned this Jun 29, 2021
@jsoriano jsoriano requested a review from mtojek June 29, 2021 16:28
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-06-29T22:28:25.122+0000

  • Duration: 10 min 46 sec

  • Commit: b7b87c1

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice to see build.yml in the wild :)

@jsoriano jsoriano merged commit 4e3fa87 into elastic:master Jun 30, 2021
@jsoriano jsoriano deleted the kafka-event-module branch June 30, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants