Skip to content

[LMD] Bugfix in the LMD transform runtime script #12427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jan 22, 2025

Conversation

sodhikirti07
Copy link
Contributor

Description

This PR fixes a bug in the transform.yml file that caused the transform to be unavailable. The issue was in the runtime_mappings script, which incorrectly assumed host.ip was always a list and assigned the second IP as destination.ip. The updated script now checks the size of host.ip and assigns the value accordingly.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

The PR was tested with elastic-package and the transform is working as expected now:
image

@sodhikirti07 sodhikirti07 added the bugfix Pull request that fixes a bug issue label Jan 22, 2025
@sodhikirti07 sodhikirti07 requested review from a team as code owners January 22, 2025 15:51
@andrewkroh andrewkroh added Integration:lmd Lateral Movement Detection Team:Security-Applied ML Elastic Security Protections Machine Learning (ML) team [elastic/sec-applied-ml] labels Jan 22, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-applied-ml (Team:Security-Applied ML)

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

@sodhikirti07 sodhikirti07 merged commit e0d61de into main Jan 22, 2025
5 checks passed
@sodhikirti07 sodhikirti07 deleted the fix-lmd-transform-bug branch January 22, 2025 18:28
@elastic-vault-github-plugin-prod

Package lmd - 2.2.0 containing this change is available at https://epr.elastic.co/package/lmd/2.2.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Fixed bug in the LMD transform runtime script
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Fixed bug in the LMD transform runtime script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:lmd Lateral Movement Detection Team:Security-Applied ML Elastic Security Protections Machine Learning (ML) team [elastic/sec-applied-ml]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants