Skip to content

Apache Tomcat made the HTTP in the log optional #12443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jan 31, 2025
Merged

Conversation

philippkahr
Copy link
Contributor

Proposed commit message

made the HTTP version inside the tomcat log optional.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    ~~- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices ~~

Related issues

@philippkahr philippkahr added the bug Something isn't working, use only for issues label Jan 23, 2025
@philippkahr philippkahr requested a review from a team as a code owner January 23, 2025 15:01
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:apache_tomcat Apache Tomcat Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] and removed bug Something isn't working, use only for issues labels Jan 23, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion. Otherwise LGTM! 🚀

@philippkahr philippkahr enabled auto-merge (squash) January 31, 2025 12:55
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #20862 succeeded 8e96a8f4325f7a28bea5dc0f6397d9a24c171cfd

@philippkahr philippkahr merged this pull request into main Jan 31, 2025
5 checks passed
@philippkahr philippkahr deleted the tomcat-grok-fix branch January 31, 2025 14:58
@elastic-vault-github-plugin-prod

Package apache_tomcat - 1.8.3 containing this change is available at https://epr.elastic.co/package/apache_tomcat/1.8.3/

harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* made the HTTP in the log optional

* fixed changelog url

* Update packages/apache_tomcat/changelog.yml

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>

---------

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>
harnish-crest-data added a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* made the HTTP in the log optional

* fixed changelog url

* Update packages/apache_tomcat/changelog.yml

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>

---------

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:apache_tomcat Apache Tomcat Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tomcat Integration - Grok failure when protocol version is missing
5 participants