Skip to content

Enhancements to Vertex AI dashboard #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jan 29, 2025
Merged

Conversation

ishleenk17
Copy link
Member

@ishleenk17 ishleenk17 commented Jan 24, 2025

Proposed commit message

Enhancements to the dashboard

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

gcp-vertexai-overview-dashboard

@ishleenk17 ishleenk17 added the enhancement New feature or request label Jan 24, 2025
@ishleenk17 ishleenk17 self-assigned this Jan 24, 2025
@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:gcp_vertexai GCP Vertex AI labels Jan 24, 2025
@ishleenk17 ishleenk17 marked this pull request as ready for review January 24, 2025 07:32
@ishleenk17 ishleenk17 requested a review from a team as a code owner January 24, 2025 07:32
@@ -23,6 +23,4 @@ streams:
description: List of GCP regions to fetch data from
multi: true
required: false
show_user: true
default:
- us-central1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the default value here, since we want the users to get the data from all the regions by default.

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jan 24, 2025
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard image needs to be updated in the img directory. Are we planning to include after final review?
While including the image, Add a Gemini model invocations, Current image includes non-Gemini models only.

@ishleenk17
Copy link
Member Author

ishleenk17 commented Jan 24, 2025

Yeah, I plan to include the image after the final review.

Add a Gemini model invocations, Current image includes non-Gemini models only.

Sure

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #20894 succeeded fd6e4d4d2cff422ba8e788ae203ebb1acbaa3e88
  • 💔 Build #20892 failed 48c4a6e0792faa7c11652cbce38316c9d96bf186

cc @ishleenk17

Copy link

@ishleenk17
Copy link
Member Author

@daniela-elastic : I plan to merge the dashboard changes today.
Please let me know if you have any comments on this.

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishleenk17 ishleenk17 merged this pull request into elastic:main Jan 29, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package gcp_vertexai - 0.4.0 containing this change is available at https://epr.elastic.co/package/gcp_vertexai/0.4.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* Update null checks anf if checks in the rename

* Update changelog.yml

* update dashboard

* Changelog

* updates

* add description to visualizations

---------

Co-authored-by: muthu-mps <muthukumar.paramasivam@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* Update null checks anf if checks in the rename

* Update changelog.yml

* update dashboard

* Changelog

* updates

* add description to visualizations

---------

Co-authored-by: muthu-mps <muthukumar.paramasivam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:gcp_vertexai GCP Vertex AI Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants