Skip to content

gitlab,ping_federate: make system tests pass on 9.0.0 #12510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jan 29, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 29, 2025

Proposed commit message

gitlab,ping_federate: make system tests pass on 9.0.0

The log input has changed file identity determination from native to
fingerprint, and the default fingerprint minimum file size is 1kiB, so make
all test inputs at least this big.

The gitlab integration did not have field mapping definitions for
log.file.fingerprint, so that is added.

Note

No changelog entry for ping_federate since there is no user-facing change here.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

First:

elastic-package stack down && elastic-package stack up -v -d --version=9.0.0-SNAPSHOT && eval "$(elastic-package stack shellinit)"

Then in each of the affected package directories:

elastic-package test system

Related issues

Screenshots

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package gitlab 👍(3) 💚(1) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 6849.32 5586.59 -1262.73 (-18.44%) 💔
auth 5263.16 3921.57 -1341.59 (-25.49%) 💔
sidekiq 13333.33 9803.92 -3529.41 (-26.47%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Copy link

@efd6 efd6 marked this pull request as ready for review January 29, 2025 04:13
@efd6 efd6 requested a review from a team as a January 29, 2025 04:13
@efd6 efd6 self-assigned this Jan 29, 2025
@efd6 efd6 added enhancement New feature or request bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 29, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged this pull request into elastic:main Jan 29, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package gitlab - 2.1.0 containing this change is available at https://epr.elastic.co/package/gitlab/2.1.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* gitlab: add support for log file fingerprint scanner configuration
* ping_federate: make test case inputs conform to fingerprint file size limits
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* gitlab: add support for log file fingerprint scanner configuration
* ping_federate: make test case inputs conform to fingerprint file size limits
@efd6 efd6 deleted the 12499-gitlab_ping_federate branch February 5, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:gitlab GitLab Integration:ping_federate PingFederate Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants