Skip to content

sublime_security: improve file selectors config documentation #12607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 4, 2025

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:sublime_security Sublime Security labels Feb 4, 2025
@efd6 efd6 self-assigned this Feb 4, 2025
@efd6 efd6 force-pushed the 12038-sublime_security branch from 21e96b5 to f6c75c6 Compare February 4, 2025 21:03
@efd6 efd6 marked this pull request as ready for review February 4, 2025 21:28
@efd6 efd6 requested a review from a team as a code owner February 4, 2025 21:28
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 force-pushed the 12038-sublime_security branch from c5f7b10 to 20d9544 Compare February 7, 2025 01:09
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #21823 failed c5f7b10cc5525e874816834250fcf2c45992a658
  • 💚 Build #21691 succeeded f6c75c69c49f643a81d171fe0343601649bb72a5

cc @efd6

Copy link

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be also changed at https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-aws-s3.html#_file_selectors?

The docs say:

content_type, parsers, include_s3_metadata,max_bytes, buffer_size, and encoding may also be set for each file selector.

But as per your investigation, when file_selectors is given, content_type is ignored?

@efd6
Copy link
Contributor Author

efd6 commented Feb 9, 2025

Probably it should be changed. The logic is here.

@efd6 efd6 merged commit 38acb88 into elastic:main Feb 9, 2025
6 checks passed
@elastic-vault-github-plugin-prod

Package sublime_security - 1.5.0 containing this change is available at https://epr.elastic.co/package/sublime_security/1.5.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:sublime_security Sublime Security Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sublime Security]: Platform Audit Logs & Message Events are not being parsed
3 participants