Skip to content

[Corelight] Update saved search of all dashboards #12634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sharadcrest
Copy link
Contributor

@sharadcrest sharadcrest commented Feb 6, 2025

Type of change

  • Enhancement

Proposed commit message

  • Update saved search of all dashboards to include only timestamps and summary of parsed logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/corelight directory.
  • Run the following command to run tests.

elastic-package test

--- Test results for package: corelight - START ---
╭───────────┬─────────────┬───────────┬────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE   │ DATA STREAM │ TEST TYPE │ TEST NAME                                                          │ RESULT │ TIME ELAPSED │
├───────────┼─────────────┼───────────┼────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ corelight │             │ asset     │ dashboard corelight-023162b6-94da-4d8d-b1f6-de6192356cce is loaded │ PASS   │      1.088µs │
│ corelight │             │ asset     │ dashboard corelight-0cfc8a95-4979-4265-b9ad-91edf63f01a9 is loaded │ PASS   │        195ns │
│ corelight │             │ asset     │ dashboard corelight-2d4dc345-cbbe-4d7a-9203-5ab11c8cb5ba is loaded │ PASS   │        173ns │
│ corelight │             │ asset     │ dashboard corelight-323b0f27-993e-4fee-ae6e-b5977d7cab11 is loaded │ PASS   │        169ns │
│ corelight │             │ asset     │ dashboard corelight-3a4a279f-f238-47de-90ba-f643c5647fde is loaded │ PASS   │        188ns │
│ corelight │             │ asset     │ dashboard corelight-40bbc19b-dd9c-4b43-a88a-e29fc8701902 is loaded │ PASS   │        199ns │
│ corelight │             │ asset     │ dashboard corelight-45197477-c13f-4e52-a5dd-fb4f53564963 is loaded │ PASS   │        222ns │
│ corelight │             │ asset     │ dashboard corelight-58885f47-95e1-4242-a1ee-783de69ace17 is loaded │ PASS   │        234ns │
│ corelight │             │ asset     │ dashboard corelight-65a5fa91-06e4-459b-b4bb-998c85a6cf08 is loaded │ PASS   │        255ns │
│ corelight │             │ asset     │ dashboard corelight-7c0946bc-acd0-4ec3-ab3b-8a92853f4a3b is loaded │ PASS   │        266ns │
│ corelight │             │ asset     │ dashboard corelight-8546a96c-86c9-4edf-9d46-88338d6ac40e is loaded │ PASS   │        270ns │
│ corelight │             │ asset     │ dashboard corelight-8c5f15f7-7063-4228-be54-fb8c20b29caa is loaded │ PASS   │        306ns │
│ corelight │             │ asset     │ dashboard corelight-e4a93cfe-4b1f-44df-ab99-50c74f6f2203 is loaded │ PASS   │        289ns │
│ corelight │             │ asset     │ dashboard corelight-eff0434c-1e27-4c02-959e-9f5d95488efb is loaded │ PASS   │        324ns │
│ corelight │             │ asset     │ dashboard corelight-f1208ffe-d168-46d1-9531-24de523d1bfb is loaded │ PASS   │        337ns │
│ corelight │             │ asset     │ dashboard corelight-f4864774-ed73-4b78-b861-5b8235ec12cf is loaded │ PASS   │        349ns │
│ corelight │             │ asset     │ dashboard corelight-f7da14f0-85db-48e8-a591-1f650af0f618 is loaded │ PASS   │        350ns │
│ corelight │             │ asset     │ dashboard corelight-ff07e65c-2703-4cbe-a45f-3881025352a3 is loaded │ PASS   │        396ns │
│ corelight │             │ asset     │ search corelight-039807c4-9ec2-4778-b548-0e08877fb8d2 is loaded    │ PASS   │        272ns │
│ corelight │             │ asset     │ search corelight-25c4969f-1368-433e-905d-fda0ae7e4923 is loaded    │ PASS   │        289ns │
│ corelight │             │ asset     │ search corelight-34498312-f418-4e47-9931-bc5fc46c0bff is loaded    │ PASS   │        235ns │
│ corelight │             │ asset     │ search corelight-845d2914-3a55-4057-9dca-a3fd4e226d54 is loaded    │ PASS   │        254ns │
│ corelight │             │ asset     │ search corelight-92c0bf7d-5abe-46a1-800d-281386e4b219 is loaded    │ PASS   │        290ns │
│ corelight │             │ asset     │ search corelight-9eee7e02-dea8-4e4b-9dc1-9d1df9785aef is loaded    │ PASS   │        283ns │
│ corelight │             │ asset     │ search corelight-a44be701-0e99-4b53-9073-b7720df40481 is loaded    │ PASS   │        296ns │
│ corelight │             │ asset     │ search corelight-e0f9718e-23ec-4c36-8040-d687fc177db4 is loaded    │ PASS   │        331ns │
╰───────────┴─────────────┴───────────┴────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: corelight - END   ---
Done

Screenshots

Before

intel

After

intel

@sharadcrest sharadcrest requested a review from a team as a code owner February 6, 2025 05:16
@sharadcrest sharadcrest changed the title Update saved search of all dashbaords [Corelight] Update saved search of all dashbaords Feb 6, 2025
@kcreddy
Copy link
Contributor

kcreddy commented Feb 7, 2025

/test

@kcreddy kcreddy added Crest Contributions from Crest developement team. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:corelight Corelight (Partner supported) labels Feb 7, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Feb 7, 2025
@kcreddy kcreddy changed the title [Corelight] Update saved search of all dashbaords [Corelight] Update saved search of all dashboards Feb 7, 2025
@sharadcrest sharadcrest requested a review from kcreddy February 10, 2025 05:47
@kcreddy
Copy link
Contributor

kcreddy commented Feb 10, 2025

/test

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

@sharadcrest sharadcrest requested a review from kcreddy February 10, 2025 06:52
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy merged commit 938aa75 into elastic:main Feb 10, 2025
6 checks passed
@elastic-vault-github-plugin-prod

Package corelight - 0.6.0 containing this change is available at https://epr.elastic.co/package/corelight/0.6.0/

@sharadcrest sharadcrest deleted the package-corelight-update-saved-search branch February 10, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crest Contributions from Crest developement team. dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:corelight Corelight (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants