Skip to content

[cloudflare_logpush] Reduce errors due to missing fields #12674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2025
Merged

[cloudflare_logpush] Reduce errors due to missing fields #12674

merged 2 commits into from
Feb 10, 2025

Conversation

simonhearne
Copy link
Contributor

Proposed commit message

Update set processors that follow optional rename processors to use ignore_empty_value in cloudflare_logpush, to avoid errors such as:

Processor "set" in pipeline "logs-cloudflare_logpush.gateway_dns-1.31.0" failed with message "field [host] not present as part of path [cloudflare_logpush.gateway_dns.host.id]"

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@simonhearne simonhearne added the enhancement New feature or request label Feb 7, 2025
@simonhearne simonhearne requested a review from a team as a code owner February 7, 2025 16:39
@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jamiehynds jamiehynds added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Feb 9, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@jamiehynds jamiehynds added the Integration:cloudflare_logpush Cloudflare Logpush label Feb 9, 2025
chemamartinez
chemamartinez approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhearne simonhearne merged commit c5eb58e into elastic:main Feb 10, 2025
6 checks passed
@simonhearne simonhearne deleted the logpush-id-fixes branch February 10, 2025 09:08
@elastic-vault-github-plugin-prod
Copy link

Package cloudflare_logpush - 1.32.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.32.0/

@chemamartinez chemamartinez mentioned this pull request Feb 10, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonhearne @elasticmachine @chemamartinez @jamiehynds