Skip to content

[cisco_ftd] Lots of new message support #12726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

jrmolin
Copy link
Contributor

@jrmolin jrmolin commented Feb 11, 2025

Proposed commit message

[cisco_ftd] Many new messages added, many messages updated

  • Requests for "fixing" FTD messages with IDs among the following:
    • 113008
    • 113009
    • 113014
    • 109201
    • 109207
    • 109210
    • 210022
    • 305012
    • 602101
    • 716058
    • 716059
    • 722051
    • 722055
    • 746012
    • 746013
  • Support added based on the examples provided by users where differing from the documentation
  • No existing test cases failed
  • New example test cases passed

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@jrmolin jrmolin added enhancement New feature or request bugfix Pull request that fixes a bug issue labels Feb 11, 2025
@jrmolin jrmolin requested a review from a team as a code owner February 11, 2025 18:59
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package cisco_ftd 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 919.96 755.86 -164.1 (-17.84%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

@jrmolin jrmolin merged commit 8a61a0a into elastic:main Feb 20, 2025
6 checks passed
@elastic-vault-github-plugin-prod

Package cisco_ftd - 3.7.0 containing this change is available at https://epr.elastic.co/package/cisco_ftd/3.7.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
* Requests for "fixing" FTD messages with IDs among the following:
  - 113008, 113009, 113014
  - 109201, 109207, 109210
  - 210022
  - 305012
  - 602101
  - 716058, 716059, 722051, 722055, 746012, 746013
* Support added based on the examples provided by users where differing from the documentation
* No existing test cases failed
* New example test cases passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:cisco_ftd Cisco FTD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants