Skip to content

Updated description on ssl node in manifest.yml owned by logstash to be uniform with other integrations #12775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

StacieClark-Elastic
Copy link
Member

Proposed commit message

Updates description field on ssl node in manifest.yml. Description is consistent with other integrations. This issue tracks change to integration owned by logstash

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Visual check of committed files

Related issues

@StacieClark-Elastic StacieClark-Elastic added Integration:logstash Logstash bugfix Pull request that fixes a bug issue labels Feb 13, 2025
@StacieClark-Elastic StacieClark-Elastic self-assigned this Feb 13, 2025
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-logstash-12707 branch from 4eb26c2 to 20d2ec1 Compare February 13, 2025 17:22
@StacieClark-Elastic StacieClark-Elastic marked this pull request as ready for review February 13, 2025 17:23
@StacieClark-Elastic StacieClark-Elastic requested a review from a team as a code owner February 13, 2025 17:23
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Feb 13, 2025

🚀 Benchmarks report

Package logstash 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
slowlog 4291.85 3205.13 -1086.72 (-25.32%) 💔

To see the full report comment with /test benchmark fullreport

Updates description field on ssl node in manifest.yml. Description is consistent with other integrations. This issue tracks change to integration owned by logstash
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-logstash-12707 branch from 20d2ec1 to b562b11 Compare February 13, 2025 22:22
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #22263 succeeded 20d2ec158b80f9e20549fc17f6a3908fb85d164c

cc @StacieClark-Elastic

Copy link

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StacieClark-Elastic StacieClark-Elastic merged commit a7204a5 into elastic:main Feb 18, 2025
6 checks passed
@elastic-vault-github-plugin-prod

Package logstash - 2.6.2 containing this change is available at https://epr.elastic.co/package/logstash/2.6.2/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
Updates description field on ssl node in manifest.yml. Description is consistent with other integrations. This issue tracks change to integration owned by logstash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:logstash Logstash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation changes for SSL node for integrations owned by logstash
3 participants