Skip to content

[AmazonMQ] Add RabbitMQ metrics dataset #12924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 5, 2025
Merged

[AmazonMQ] Add RabbitMQ metrics dataset #12924

merged 7 commits into from
Mar 5, 2025

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Feb 28, 2025 •
edited
Loading

  • Enhancement

Proposed commit message

  • Add support for RabbitMQ metrics.
  • Add minor documentation updates.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Integration testing with producer clients and consumer clients
  • Comparison of values with RabbitMQ console metrics
  • Metrics dependencies on dimensions and adjustments
  • TSDS enablement testing

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Screenshots

image

@agithomas agithomas added enhancement New feature or request Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:aws_mq Amazon MQ labels Feb 28, 2025
@agithomas agithomas self-assigned this Feb 28, 2025
@agithomas agithomas marked this pull request as ready for review February 28, 2025 13:50
@agithomas agithomas requested a review from a team as a code owner February 28, 2025 13:50
gpop63
gpop63 reviewed Mar 3, 2025
View reviewed changes
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @agithomas

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
23.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

devamanv
devamanv reviewed Mar 4, 2025
View reviewed changes
devamanv
devamanv approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few small comments, rest looks good.

@agithomas agithomas merged commit 7a02fac into elastic:main Mar 5, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package aws_mq - 0.3.0 containing this change is available at https://epr.elastic.co/package/aws_mq/0.3.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@agithomas @flexitrev
[AmazonMQ] Add RabbitMQ metrics dataset (#12924)
8d54412 
* Add RabbitMQ metrics dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devamanv devamanv devamanv approved these changes

@gpop63 gpop63 gpop63 approved these changes

Assignees

@agithomas agithomas

Labels
enhancement New feature or request Integration:aws_mq Amazon MQ Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agithomas @elasticmachine @devamanv @gpop63