-
Notifications
You must be signed in to change notification settings - Fork 474
[Logstash pkg] Add Kibana 9.0 support. #12982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
log |
0 | 4219.41 | 4219.41 ( - %) | 👍 |
slowlog |
0 | 4098.36 | 4098.36 ( - %) | 👍 |
@@ -14,7 +14,7 @@ categories: | |||
- elastic_stack | |||
conditions: | |||
kibana: | |||
version: ^8.17.0 | |||
version: "^8.17.0 || ^9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a regexp matching, the "version start with 8.17.0 or 9.0.0". What happens for other subsequent versions like next patch or next minor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe ^ means that version or higher within the same major. examples of 8.0.0: https://github.com/elastic/integrations/pull/2683/files#diff-c7d44de822376fccaf7d57df203bc6fb4d50043e28efb7346fd629ef40b928d5R12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ behaves here as @jsvd explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(came to my desk and linking the resource)
Here is the guideline for this: https://github.com/elastic/elastic-package/blob/main/docs/howto/stack_version_support.md#guidelines-for-version-constraints
/test benchmark fullreport |
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package logstash - 2.7.0 containing this change is available at https://epr.elastic.co/package/logstash/2.7.0/ |
Proposed commit message
Updates the Logstash package to make it available in Kibana 9.0
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots