Skip to content

[Logstash pkg] Add Kibana 9.0 support. #12982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

mashhurs
Copy link
Contributor

@mashhurs mashhurs commented Mar 6, 2025

Proposed commit message

Updates the Logstash package to make it available in Kibana 9.0

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@mashhurs mashhurs requested a review from flexitrev March 6, 2025 05:11
@mashhurs mashhurs requested a review from a team as a code owner March 6, 2025 05:12
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 6, 2025

🚀 Benchmarks report

Package logstash 👍(2) 💚(0) 💔(0)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 0 4219.41 4219.41 ( - %) 👍
slowlog 0 4098.36 4098.36 ( - %) 👍

@@ -14,7 +14,7 @@ categories:
- elastic_stack
conditions:
kibana:
version: ^8.17.0
version: "^8.17.0 || ^9.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a regexp matching, the "version start with 8.17.0 or 9.0.0". What happens for other subsequent versions like next patch or next minor?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ behaves here as @jsvd explained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsvd
Copy link
Member

jsvd commented Mar 6, 2025

/test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

@mashhurs mashhurs requested a review from jsvd March 10, 2025 16:33
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashhurs mashhurs merged commit 92573f5 into elastic:main Mar 11, 2025
7 checks passed
@mashhurs mashhurs deleted the support-kb-9.0-for-ls-package branch March 11, 2025 14:34
@elastic-vault-github-plugin-prod

Package logstash - 2.7.0 containing this change is available at https://epr.elastic.co/package/logstash/2.7.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@mashhurs mashhurs changed the title Add Kibana 9.0 support. [Logstash pkg] Add Kibana 9.0 support. May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants