-
Notifications
You must be signed in to change notification settings - Fork 474
[AmazonMQ] RabbitMQ - Add overview dashboard #13032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few points based on the 'Observability integrations dashboards best practices' guidelines:
- Use hyphen "-" to separate complex widget names that are broken down by certain entity such as "by node", "by broker", etc.
- Remove the word "count" or other similar synonyms where it seems redundant. For example, instead of "Queue count", replace with "Queues"; instead of "Total messages count", replace by "Total messages"; instead of "Messages ready count", replace with "Messages ready" or maybe even "Ready messages"; instead of "Consumer count", replace with "Consumers", and so on and so forth.
- Name each section of the dashboard. The first section is unnamed (it contains resource utilization metrics and a melange of connections, consumers, messages and rates), in addition to two named sections for Node metrics and Queue metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Can we expand the control section in such a way that it fits the screen width?
-
Change the title and corresponding labels from
Un-acknowledged
toUnacknowledged
. -
And for
Acknowledgment
, Can we update toAcknowledgement
? As both are correct by making this change it becomes more aligned with the field descriptions. WDYT?
description: The number of messages for which the server is awaiting acknowledgement.
Thanks, @muthu-mps for the feedback, I have addressed the suggestions. |
The right axis label for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the "Broker metrics" headline for the first 2 rows of the dashboard?
This is for the first three rows until the section "Node Metrics" |
Great catch. Addressed. |
💚 Build Succeeded
History
cc @agithomas |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package aws_mq - 0.4.0 containing this change is available at https://epr.elastic.co/package/aws_mq/0.4.0/ |
* AmazonMQ RabbitMQ Add overview dashboard
Proposed commit message
Add overview dashboard for RabbitMQ in ActiveMQ
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
elastic-package build
elastic-package stack up -v -d --services package-registry
Screenshots