Skip to content

[AmazonMQ] RabbitMQ - Add overview dashboard #13032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2025

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Mar 10, 2025

  • Enhancement

Proposed commit message

Add overview dashboard for RabbitMQ in ActiveMQ

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Integration testing
  • Verified that the ActiveMQ related broker / queue / topic details are not appearing in the dashboard

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Screenshots

amazonmq-rabbitmq-overview

@agithomas agithomas self-assigned this Mar 10, 2025
@agithomas agithomas added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:aws_mq Amazon MQ Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] enhancement New feature or request labels Mar 10, 2025
@agithomas agithomas marked this pull request as ready for review March 10, 2025 06:13
@agithomas agithomas requested a review from a team as a code owner March 10, 2025 06:13
Copy link

@daniela-elastic daniela-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points based on the 'Observability integrations dashboards best practices' guidelines:

  1. Use hyphen "-" to separate complex widget names that are broken down by certain entity such as "by node", "by broker", etc.
  2. Remove the word "count" or other similar synonyms where it seems redundant. For example, instead of "Queue count", replace with "Queues"; instead of "Total messages count", replace by "Total messages"; instead of "Messages ready count", replace with "Messages ready" or maybe even "Ready messages"; instead of "Consumer count", replace with "Consumers", and so on and so forth.
  3. Name each section of the dashboard. The first section is unnamed (it contains resource utilization metrics and a melange of connections, consumers, messages and rates), in addition to two named sections for Node metrics and Queue metrics.

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we expand the control section in such a way that it fits the screen width?

    Screenshot 2025-03-14 at 12 53 45 PM
  • Change the title and corresponding labels from Un-acknowledged to Unacknowledged.

  • And for Acknowledgment, Can we update to Acknowledgement? As both are correct by making this change it becomes more aligned with the field descriptions. WDYT?

    description: The number of messages for which the server is awaiting acknowledgement.

@agithomas
Copy link
Contributor Author

Thanks, @muthu-mps for the feedback, I have addressed the suggestions.
The width of the control section I would prefer to keep it as it is - in a high-resolution display when extending to full width, it leads to accessibility issues.

@muthu-mps
Copy link
Contributor

Thanks, @muthu-mps for the feedback, I have addressed the suggestions. The width of the control section I would prefer to keep it as it is - in a high-resolution display when extending to full width, it leads to accessibility issues.

The right axis label for Total messages Vs Ready messages Vs unacknowledged messages needs an update.

@daniela-elastic daniela-elastic self-requested a review March 14, 2025 12:22
Copy link

@daniela-elastic daniela-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "Broker metrics" headline for the first 2 rows of the dashboard?

@agithomas
Copy link
Contributor Author

agithomas commented Mar 14, 2025

Is the "Broker metrics" headline for the first 2 rows of the dashboard?

This is for the first three rows until the section "Node Metrics"

@agithomas
Copy link
Contributor Author

The right axis label for Total messages Vs Ready messages Vs unacknowledged messages needs an update.

Great catch. Addressed.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @agithomas

Copy link

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 65a68e8 into elastic:main Mar 14, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package aws_mq - 0.4.0 containing this change is available at https://epr.elastic.co/package/aws_mq/0.4.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
* AmazonMQ RabbitMQ Add overview dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:aws_mq Amazon MQ Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants