Skip to content

[cisco_ftd] Message 302304 (and similar) has flexible spacing #13043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

[cisco_ftd] Message 302304 (and similar) has flexible spacing #13043

merged 2 commits into from
Mar 10, 2025

Conversation

jrmolin
Copy link
Contributor

@jrmolin jrmolin commented Mar 10, 2025

Proposed commit message

[cisco_ftd] Grok fix for 302304 message

  • A 302304 message has been seen with different spacing (more spaces) than the existing grok patterns
  • Flexible spacing support added where appropriate
  • New example log passes
  • No existing logs are broken

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@jrmolin jrmolin added the bugfix Pull request that fixes a bug issue label Mar 10, 2025
@jrmolin jrmolin marked this pull request as ready for review March 10, 2025 15:40
@jrmolin jrmolin requested a review from a team as a code owner March 10, 2025 15:40
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

taylor-swanson
taylor-swanson approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylor-swanson taylor-swanson added Integration:cisco_ftd Cisco FTD Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Mar 10, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@jrmolin jrmolin merged commit 6ed0e50 into elastic:main Mar 10, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package cisco_ftd - 3.7.1 containing this change is available at https://epr.elastic.co/package/cisco_ftd/3.7.1/

@jrmolin jrmolin deleted the cisco-302304-grok-error branch March 10, 2025 18:24
flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@jrmolin @flexitrev
[cisco_ftd] Message 302304 (and similar) has flexible spacing (#13043)
1a6f2b1 
* A 302304 message has been seen with different spacing (more spaces) than the existing grok patterns
* Flexible spacing support added where appropriate
* New example log passes
* No existing logs are broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees
No one assigned
Labels
bugfix Pull request that fixes a bug issue Integration:cisco_ftd Cisco FTD Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrmolin @elasticmachine @taylor-swanson