Skip to content

threat_map: remove unnecessary policy definition #13069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

threat_map: remove unnecessary policy definition #13069

merged 1 commit into from
Mar 12, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 12, 2025 •
edited
Loading

Proposed commit message

threat_map: remove unnecessary policy definition

The package is dashboard-only, so there should be no policy defined here.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:threat_map Threat Map labels Mar 12, 2025
@efd6 efd6 self-assigned this Mar 12, 2025
@efd6 efd6 force-pushed the 13017-threat_map branch from 2402a16 to df96221 Compare March 12, 2025 02:51
@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review March 12, 2025 03:29
@efd6 efd6 requested a review from a team as a code owner March 12, 2025 03:29
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
May I know if the upgrade process is tested?
Does it cause any issue during upgrade?

@efd6
Copy link
Contributor Author

efd6 commented Mar 12, 2025

I will check.

@efd6
Copy link
Contributor Author

efd6 commented Mar 12, 2025

Confirmed that this is safe.

@efd6 efd6 merged commit b6e44e4 into elastic:main Mar 12, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package threat_map - 0.2.1 containing this change is available at https://epr.elastic.co/package/threat_map/0.2.1/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@efd6 @flexitrev
threat_map: remove unnecessary policy definition (#13069)
7760a15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:threat_map Threat Map Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Threat Map]: Threat Map breaks all other integrations using the log input
3 participants
@efd6 @elasticmachine @kcreddy