Skip to content

[system/process][system/process_summary] Add support degrade_on_partial #13074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 4, 2025

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Mar 12, 2025

Add support for degrade_on_partial variable exposed by elastic/elastic-agent#6640 and elastic/beats#42160.

Screenshot 2025-05-04 at 6 37 33 PM

@VihasMakwana VihasMakwana requested review from a team as code owners March 12, 2025 13:45
@VihasMakwana VihasMakwana self-assigned this Mar 12, 2025
@VihasMakwana VihasMakwana added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Mar 12, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] labels Mar 12, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@VihasMakwana
Copy link
Contributor Author

Folks, can someone take a look?

@VihasMakwana VihasMakwana requested a review from andrewkroh March 21, 2025 18:00
@andrewkroh andrewkroh added the enhancement New feature or request label Mar 21, 2025
@VihasMakwana VihasMakwana requested a review from andrewkroh April 13, 2025 19:29
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@@ -78,6 +78,23 @@ policy_templates:
required: false
show_user: true
description: The proc filesystem base directory.
- name: degrade_on_partial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new config added in beats. Can you please confirm its present in which stack versions.
Do we need to update the kibana version here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be available in 9.x release. We kibana version at 9.0.0

version: "^8.17.0 || ^9.0.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this config option is true only for process and process_summary. Let's put it in manifest for just those 2 datastreams. This way this config option will appear for all datastreams which is incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishleenk17 this should be good to go now. Can you take another look?

VihasMakwana and others added 2 commits April 16, 2025 19:02
Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
@VihasMakwana VihasMakwana requested a review from ishleenk17 April 24, 2025 15:11
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @VihasMakwana

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
52.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@VihasMakwana VihasMakwana merged commit e990690 into elastic:main May 4, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod

Package system - 1.69.0 containing this change is available at https://epr.elastic.co/package/system/1.69.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants