entityanalytics_ad: do not rename msDS-* fields #13094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
efd6
force-pushed
the
entityanalytics_ad_subtle
branch
from
aa1e50e to
7e04a21
Compare
Apparently there are 322 msDS-* fields, so we either enumerate them in the look-up table or hope that camelCase to snake_case is not lossy for any of them if we want to do renames. Rather than doing that, accept that we cannot rename any of them and revert this single case to retain a consistent naming convention for them.
efd6
force-pushed
the
entityanalytics_ad_subtle
branch
from
7e04a21 to
80c6fca
Compare
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @efd6 |
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
w0rk3r
approved these changes
Mar 13, 2025
kcreddy
approved these changes
Mar 13, 2025
|
Package entityanalytics_ad - 0.9.0 containing this change is available at https://epr.elastic.co/package/entityanalytics_ad/0.9.0/ |
flexitrev
pushed a commit
that referenced
this pull request
Mar 20, 2025
Apparently there are 322 msDS-* fields, so we either enumerate them in the look-up table or hope that camelCase to snake_case is not lossy for any of them if we want to do renames. Rather than doing that, accept that we cannot rename any of them and revert this single case to retain a consistent naming convention for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Note
Strictly breaking, but we are before v1.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots