Skip to content

[Amazon MQ] Add support for ActiveMQ general logs #13136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 18, 2025

Conversation

agithomas
Copy link
Contributor

  • Enhancement

Proposed commit message

Add support for ingesting AmazonMQ's ActiveMQ general logs using Cloudwatch Loggroup.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Field name compatibility, whenever possible, with existing ActiveMQ
  • Integration testing
  • Pipeline test

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Screenshots

Dashboard changes are not part of this enhancement. No screenshots added.

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@agithomas agithomas marked this pull request as ready for review March 17, 2025 06:00
@agithomas agithomas requested a review from a team as a code owner March 17, 2025 06:00
@agithomas agithomas requested a review from gpop63 March 17, 2025 10:39
@andrewkroh andrewkroh added Integration:aws_mq Amazon MQ Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Mar 17, 2025
@agithomas agithomas self-assigned this Mar 17, 2025
@muthu-mps
Copy link
Contributor

Hi @agithomas

  • Can we add a sample-events.json and include it to the document?
  • Update the compatibility and the data streams section to mention the support for logs.
  • The Amazon MQ integration collects Apache ActiveMQ and RabbitMQ metrics.

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @agithomas

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
36.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@agithomas agithomas merged commit fdbe8ef into elastic:main Mar 18, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod

Package aws_mq - 0.5.0 containing this change is available at https://epr.elastic.co/package/aws_mq/0.5.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:aws_mq Amazon MQ Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants