Skip to content

checkpoint_harmony_endpoint: fix assignment of endTime query parameter #13200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

Fixing a CEL condition that made the endTime query parameter being null when state.cursor.next_endTime is also null, leading to the following error:

 {"success":false,"error":{"status":400,"name":"Bad Request","details":["endTime should not be empty"]}}

Note

All data streams have identical cel.yml.hbs files.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chemamartinez chemamartinez added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint labels Mar 20, 2025
@chemamartinez chemamartinez self-assigned this Mar 20, 2025
@chemamartinez chemamartinez marked this pull request as ready for review March 20, 2025 17:42
@chemamartinez chemamartinez requested a review from a team as a code owner March 20, 2025 17:42
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez chemamartinez requested a review from kcreddy March 21, 2025 13:30
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chemamartinez

Copy link

@chemamartinez chemamartinez merged commit d4aa02e into elastic:main Mar 21, 2025
7 checks passed
@chemamartinez chemamartinez deleted the checkpoint_harmony_endpoint-fix-endTime branch March 21, 2025 14:08
@elastic-vault-github-plugin-prod

Package checkpoint_harmony_endpoint - 0.5.1 containing this change is available at https://epr.elastic.co/package/checkpoint_harmony_endpoint/0.5.1/

flexitrev pushed a commit that referenced this pull request Mar 25, 2025
#13200)

Fixing a CEL condition that made the endTime query parameter being null when state.cursor.next_endTime is also null.
flexitrev pushed a commit that referenced this pull request Mar 28, 2025
#13200)

Fixing a CEL condition that made the endTime query parameter being null when state.cursor.next_endTime is also null.
flexitrev pushed a commit that referenced this pull request Mar 28, 2025
#13200)

Fixing a CEL condition that made the endTime query parameter being null when state.cursor.next_endTime is also null.
flexitrev pushed a commit that referenced this pull request Mar 28, 2025
#13200)

Fixing a CEL condition that made the endTime query parameter being null when state.cursor.next_endTime is also null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants