checkpoint_harmony_endpoint: improve handling of API errors

[chemamartinez]

Proposed commit message

The two changes included are:
- The handling of the 404 error when hitting the retrieve endpoint (that happens when the integration already received a valid task ID and page token, in this case, both parameters are cleaned and a new task ID is requested again for the same timeframe.
- In the generic error handling, also clean task ID and page token to avoid entering in a loop making requests with stale parameters.

Note

All data streams have identical cel.yml.hbs files.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.
• I have verified that any added dashboard complies with Kibana's Dashboard good practices

[elasticmachine]

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

[elastic-vault-github-plugin-prod]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[chrisberkhout]

The 404 changes look good.

For the generic error handling changes, is it intentional that the time advances? It seems like it should also repeat.

[chemamartinez]

The 404 changes look good.

For the generic error handling changes, is it intentional that the time advances? It seems like it should also repeat.

@chrisberkhout, yes, that makes sense I think. I've trying to get some troubleshooting advices from the API docs but unfortunately there's nothing there.

Do you think it would be worthy to merge both 404 and generic cases by setting want_more: false in 404 case? that would simplify the error logic.

[chrisberkhout]

Do you think it would be worthy to merge both 404 and generic cases by setting want_more: false in 404 case? that would simplify the error logic.

Yes, good idea!

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: d38f503

History

• 💚 Build #23968 succeeded bbe69de

cc @chemamartinez

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elastic-vault-github-plugin-prod]

Package checkpoint_harmony_endpoint - 0.6.0 containing this change is available at https://epr.elastic.co/package/checkpoint_harmony_endpoint/0.6.0/