Skip to content

[Entity Analytics AD] Add config option to set TLS options #13362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2025
Merged

[Entity Analytics AD] Add config option to set TLS options #13362

merged 6 commits into from
Apr 2, 2025

Conversation

moxarth-rathod
Copy link
Contributor

Proposed commit message

Adding a new configuration option to set TLS for the input in the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

How to test this PR locally

Related issues

@moxarth-rathod moxarth-rathod added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:entityanalytics_ad Active Directory Entity Analytics Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Mar 31, 2025
@moxarth-rathod moxarth-rathod self-assigned this Mar 31, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner March 31, 2025 13:07
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@moxarth-rathod moxarth-rathod marked this pull request as draft March 31, 2025 13:08
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@moxarth-rathod moxarth-rathod marked this pull request as ready for review April 1, 2025 05:18
kcreddy
kcreddy reviewed Apr 1, 2025
View reviewed changes
packages/entityanalytics_ad/data_stream/user/manifest.yml Outdated
- name: ssl
type: yaml
title: SSL Configuration
description: i.e. certificate_authorities, supported_protocols, verification_mode etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the description from here?
https://github.com/elastic/integrations/pull/12781/files

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

@moxarth-rathod moxarth-rathod requested a review from kcreddy April 2, 2025 06:20
@kcreddy kcreddy merged commit 6c63a6a into elastic:main Apr 2, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package entityanalytics_ad - 0.12.0 containing this change is available at https://epr.elastic.co/package/entityanalytics_ad/0.12.0/

flexitrev pushed a commit that referenced this pull request Apr 3, 2025
@moxarth-rathod @flexitrev
[Entity Analytics AD] Add config option to set TLS options (#13362)
cd0dd3e 
Adding a new configuration option to set TLS for the input in the integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@moxarth-rathod moxarth-rathod

Labels
enhancement New feature or request Integration:entityanalytics_ad Active Directory Entity Analytics Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[entityanalytics_ad] Add config option to set TLS options
3 participants
@moxarth-rathod @elasticmachine @kcreddy