Skip to content

updating disclaimer for aws_cloudwatch logs #13370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2025
Merged

updating disclaimer for aws_cloudwatch logs #13370

merged 4 commits into from
Apr 3, 2025

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Apr 1, 2025

  • Breaking change

Proposed commit message

Please explain:

  • WHAT: We change the default value of the cloudwatch_lods data_stream.dataset to aws.cloudwatch_logs
  • WHY: This needs to match the package name cloudwatch_logs in order the preinstalled ingest mappings/templates for the given datastream to apply

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone dir
  • cd packages/integrations/kubernetes
  • elastic-package build
  • elastic-package stack up -d -vvv --version=9.0.0-SNAPSHOT
  • Create an elastic-agent policy
  • Add kubernetes integration. The version 2.45.0 should be available

Related issues

Screenshots

This is how the discalimer is displayed:

Screenshot 2025-04-02 at 4 26 19 PM

The default ingest template is displayed below:

Screenshot 2025-04-02 at 4 33 04 PM

So we changed the datastream.dataset to aws.cloudwatch_logs

Successful processing of cloudwatch events:
Screenshot 2025-04-02 at 5 48 48 PM

Important: We enable the preserve_original event that is defined in ingest pipeline

This one works fine as you can see in previous image

But we test again with version 2.44.0:

Screenshot 2025-04-02 at 6 02 54 PM

See that event.original is not present and that that preserve_original.event is present that indicates that the option was enabled.

gizas added 3 commits April 1, 2025 13:50
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh changed the title updating desclaimer for aws_cloudwatch logs updating disclaimer for aws_cloudwatch logs Apr 1, 2025
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@gizas gizas marked this pull request as ready for review April 2, 2025 15:11
@gizas gizas requested review from a team as code owners April 2, 2025 15:11
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andrewkroh andrewkroh added the Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] label Apr 2, 2025
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

@gizas gizas merged commit 662bd7e into main Apr 3, 2025
7 checks passed
@gizas gizas deleted the fixcloudwatch branch April 3, 2025 06:59
@elastic-vault-github-plugin-prod

Package aws - 2.45.0 containing this change is available at https://epr.elastic.co/package/aws/2.45.0/

flexitrev pushed a commit that referenced this pull request Apr 3, 2025
* updating disclaimer for aws_cloudwatch logs

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

---------

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants