Skip to content

Add new AWS Security Hub Findings Full Posture data stream and update misconfig transform to use it #13372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 17, 2025

Conversation

maxcold
Copy link
Contributor

@maxcold maxcold commented Apr 1, 2025

Proposed commit message

Similar to #12961, adding a new AWS Security Hub Findings Full Posture data stream, which in contrast to the existing AWS Security Hub Findings data stream, ingests all Security Hub Findings data every 24h to match the logic of the native Cloud Security Posture integration used by cloudbeat. Updated latest misconfigurations transform to use this new data stream as a source. Due to the change in the transform, this might be a breaking change for customers, they need to enable the new data stream when updating to still receive findings in their Findings > Misconfigurations view and other flows relying on cloud security posture data

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

  1. build package with elastic-package build
  2. start the stack corresponding to the Kibana version from the manifest with elastic-package stack up
  3. Install the integration and ingest AWS Security Hub Findings Full Posture data, findings from AWS should appear in Findings > Misconfiguration

Related issues

Related to:

Screenshots

@maxcold maxcold added Integration:aws AWS breaking change Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Apr 1, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Apr 2, 2025

🚀 Benchmarks report

Package aws 👍(11) 💚(5) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
inspector 1988.07 1658.37 -329.7 (-16.58%) 💔
route53_public_logs 12820.51 10000 -2820.51 (-22%) 💔
apigateway_logs 9803.92 6410.26 -3393.66 (-34.62%) 💔
firewall_logs 3623.19 2808.99 -814.2 (-22.47%) 💔

To see the full report comment with /test benchmark fullreport

@maxcold maxcold marked this pull request as ready for review April 3, 2025 09:54
@maxcold maxcold requested review from a team as code owners April 3, 2025 09:54
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@maxcold maxcold requested a review from a team April 3, 2025 09:55
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Apr 3, 2025
Copy link
Contributor

@seanrathier seanrathier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, lots of detail here beyond my current integration knowledge so I will approve. Maybe another reviewer will notice something.

maxcold and others added 6 commits April 14, 2025 13:44
@maxcold maxcold requested a review from kcreddy April 16, 2025 10:03
value: '[[formatDate (now) "20060102T150405Z"]]'
- set:
target: body.MaxResults
value: 500
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcreddy it looks like 100 is maximum in AWS SDK, i get error

Error while processing http request: failed to collect first response: failed to execute http POST: server responded with status code 400: {"Code":"InvalidInputException","Type":"InvalidInputException","RequestId":"a31ba92d-e9e8-4299-b2e3-493651a7fdb0","Message":"Invalid parameter 'MaxResults'. '500' is greater than maximum value: 100."}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info

@andrewkroh andrewkroh added the Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] label Apr 16, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
73.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@maxcold maxcold merged commit 7189d7b into elastic:main Apr 17, 2025
6 of 7 checks passed
@maxcold maxcold deleted the csp-aws-sec-hub-full-posture branch April 17, 2025 10:25
@elastic-vault-github-plugin-prod

Package aws - 3.0.0 containing this change is available at https://epr.elastic.co/package/aws/3.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Integration:aws AWS Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants