-
Notifications
You must be signed in to change notification settings - Fork 474
Add new AWS Security Hub Findings Full Posture data stream and update misconfig transform to use it #13372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
inspector |
1988.07 | 1658.37 | -329.7 (-16.58%) | 💔 |
route53_public_logs |
12820.51 | 10000 | -2820.51 (-22%) | 💔 |
apigateway_logs |
9803.92 | 6410.26 | -3393.66 (-34.62%) | 💔 |
firewall_logs |
3623.19 | 2808.99 | -814.2 (-22.47%) | 💔 |
To see the full report comment with /test benchmark fullreport
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, lots of detail here beyond my current integration knowledge so I will approve. Maybe another reviewer will notice something.
packages/aws/data_stream/securityhub_findings_full_posture/agent/stream/httpjson.yml.hbs
Show resolved
Hide resolved
Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
value: '[[formatDate (now) "20060102T150405Z"]]' | ||
- set: | ||
target: body.MaxResults | ||
value: 500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcreddy it looks like 100 is maximum in AWS SDK, i get error
Error while processing http request: failed to collect first response: failed to execute http POST: server responded with status code 400: {"Code":"InvalidInputException","Type":"InvalidInputException","RequestId":"a31ba92d-e9e8-4299-b2e3-493651a7fdb0","Message":"Invalid parameter 'MaxResults'. '500' is greater than maximum value: 100."}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info
💚 Build Succeeded
History
|
|
Package aws - 3.0.0 containing this change is available at https://epr.elastic.co/package/aws/3.0.0/ |
Proposed commit message
Similar to #12961, adding a new
AWS Security Hub Findings Full Posture
data stream, which in contrast to the existingAWS Security Hub Findings
data stream, ingests all Security Hub Findings data every 24h to match the logic of the native Cloud Security Posture integration used bycloudbeat
. Updated latest misconfigurations transform to use this new data stream as a source. Due to the change in the transform, this might be a breaking change for customers, they need to enable the new data stream when updating to still receive findings in their Findings > Misconfigurations view and other flows relying on cloud security posture dataChecklist
changelog.yml
file.Author's Checklist
How to test this PR locally
elastic-package build
elastic-package stack up
Related issues
Related to:
Screenshots