Skip to content

cloudflare_logpush: add tests for gateway_{dns,http} #13451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

cloudflare_logpush: add tests for gateway_{dns,http} #13451

merged 1 commit into from
Apr 8, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 7, 2025

Proposed commit message

cloudflare_logpush: add tests for gateway_{dns,http}

Fix geoip processor issues that were exposed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Apr 7, 2025
@efd6 efd6 self-assigned this Apr 7, 2025
@efd6 efd6 force-pushed the 13392-cloudflare_logpush-gateway_dns-gateway_http branch from 7419684 to 12f8e9a Compare April 7, 2025 21:54
@efd6
cloudflare_logpush: add tests for gateway_{dns,http}
1f3ab93 
Fix geoip processor issues that were exposed.
@efd6 efd6 force-pushed the 13392-cloudflare_logpush-gateway_dns-gateway_http branch from 12f8e9a to 1f3ab93 Compare April 7, 2025 23:10
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

Package cloudflare_logpush 👍(15) 💚(5) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 9615.38 5291.01 -4324.37 (-44.97%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review April 7, 2025 23:47
@efd6 efd6 requested a review from a team as a code owner April 7, 2025 23:47
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

chemamartinez
chemamartinez approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 9cada59 into elastic:main Apr 8, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package cloudflare_logpush - 1.37.2 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.37.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @chemamartinez