Skip to content

Removed event.original processors from network and network-obs relate… #13520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 13, 2025
Merged

Removed event.original processors from network and network-obs relate… #13520

merged 13 commits into from
Jun 13, 2025

Conversation

Alphayeeeet
Copy link
Contributor

Label as enhancement

Proposed commit message

Remove event.original removal processors

Related issues

Review #10072 for additional info

@Alphayeeeet Alphayeeeet requested review from a team as code owners April 12, 2025 10:17
@andrewkroh andrewkroh added Integration:fortinet_fortimanager Fortinet FortiManager Logs Integration:microsoft_dhcp Microsoft DHCP Integration:iptables Iptables Integration:istio Istio Integration:panw Palo Alto Next-Gen Firewall Integration:sonicwall_firewall SonicWall Firewall Integration:juniper_srx Juniper SRX Integration:nagios_xi Nagios XI Integration:juniper_netscreen Juniper NetScreen (Deprecated) Integration:fortinet_fortiedr Fortinet FortiEDR Logs Integration:stormshield StormShield SNS Integration:netscout Arbor Peakflow SP Logs (Deprecated) Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Integration:juniper_junos Juniper JunOS (Deprecated) Integration:snort Snort Integration:pfsense pfSense (Community supported) Integration:suricata Suricata Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 14, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@Alphayeeeet
Copy link
Contributor Author

@andrewkroh My bad, didn't knew that juniper integrations were already deprecated. Unfortunately they had no obvious note in the manifest or changelog

@andrewkroh
Copy link
Member

These are the CI error (which were surprisingly hard to find):

Error: checking package failed: linting package failed: found 3 validation errors:
   1. file "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812224830176354/elastic/integrations/packages/juniper_junos/changelog.yml" is invalid: unmarshalling YAML file failed: yaml: line 6: did not find expected key
   2. can't read changelog entries: unmarshalling YAML file failed (path: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812224830176354/elastic/integrations/packages/juniper_junos/changelog.yml): yaml: line 6: did not find expected key
   3. can't read changelog entries: unmarshalling YAML file failed (path: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812224830176354/elastic/integrations/packages/juniper_junos/changelog.yml): yaml: line 6: did not find expected key

Error: checking package failed: linting package failed: found 3 validation errors:
   1. file "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812229453498827/elastic/integrations/packages/juniper_netscreen/changelog.yml" is invalid: unmarshalling YAML file failed: yaml: line 6: did not find expected key
   2. can't read changelog entries: unmarshalling YAML file failed (path: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812229453498827/elastic/integrations/packages/juniper_netscreen/changelog.yml): yaml: line 6: did not find expected key
   3. can't read changelog entries: unmarshalling YAML file failed (path: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812229453498827/elastic/integrations/packages/juniper_netscreen/changelog.yml): yaml: line 6: did not find expected key

Error: checking package failed: linting package failed: found 3 validation errors:
   1. file "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812226292349201/elastic/integrations/packages/netscout/changelog.yml" is invalid: unmarshalling YAML file failed: yaml: line 6: did not find expected key
   2. can't read changelog entries: unmarshalling YAML file failed (path: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812226292349201/elastic/integrations/packages/netscout/changelog.yml): yaml: line 6: did not find expected key
   3. can't read changelog entries: unmarshalling YAML file failed (path: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1749812226292349201/elastic/integrations/packages/netscout/changelog.yml): yaml: line 6: did not find expected key

andrewkroh
andrewkroh reviewed Jun 13, 2025
View reviewed changes
auto-merge was automatically disabled June 13, 2025 14:20

Head branch was pushed to by a user without write access

@Alphayeeeet
Copy link
Contributor Author

@andrewkroh Can we try running CI again?

@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@Alphayeeeet
Copy link
Contributor Author

@andrewkroh Can you please merge the PR. CI tests came back successfully. Thanks

@andrewkroh andrewkroh merged commit 819b8e2 into elastic:main Jun 13, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package fortinet_fortiedr - 1.19.0 containing this change is available at https://epr.elastic.co/package/fortinet_fortiedr/1.19.0/

@elastic-vault-github-plugin-prod
Copy link

Package fortinet_fortigate - 1.33.0 containing this change is available at https://epr.elastic.co/package/fortinet_fortigate/1.33.0/

@elastic-vault-github-plugin-prod
Copy link

Package fortinet_fortimanager - 2.16.0 containing this change is available at https://epr.elastic.co/package/fortinet_fortimanager/2.16.0/

@elastic-vault-github-plugin-prod
Copy link

Package iptables - 1.21.0 containing this change is available at https://epr.elastic.co/package/iptables/1.21.0/

@elastic-vault-github-plugin-prod
Copy link

Package istio - 0.8.0 containing this change is available at https://epr.elastic.co/package/istio/0.8.0/

@elastic-vault-github-plugin-prod
Copy link

Package juniper_junos - 0.12.0 containing this change is available at https://epr.elastic.co/package/juniper_junos/0.12.0/

@elastic-vault-github-plugin-prod
Copy link

Package juniper_netscreen - 0.12.0 containing this change is available at https://epr.elastic.co/package/juniper_netscreen/0.12.0/

@elastic-vault-github-plugin-prod
Copy link

Package juniper_srx - 1.24.0 containing this change is available at https://epr.elastic.co/package/juniper_srx/1.24.0/

@elastic-vault-github-plugin-prod
Copy link

Package microsoft_dhcp - 1.27.0 containing this change is available at https://epr.elastic.co/package/microsoft_dhcp/1.27.0/

@elastic-vault-github-plugin-prod
Copy link

Package nagios_xi - 1.6.0 containing this change is available at https://epr.elastic.co/package/nagios_xi/1.6.0/

@elastic-vault-github-plugin-prod
Copy link

Package netscout - 0.22.0 containing this change is available at https://epr.elastic.co/package/netscout/0.22.0/

@elastic-vault-github-plugin-prod
Copy link

Package panw - 5.3.0 containing this change is available at https://epr.elastic.co/package/panw/5.3.0/

@elastic-vault-github-plugin-prod
Copy link

Package pfsense - 1.23.0 containing this change is available at https://epr.elastic.co/package/pfsense/1.23.0/

@elastic-vault-github-plugin-prod
Copy link

Package snort - 1.19.0 containing this change is available at https://epr.elastic.co/package/snort/1.19.0/

@elastic-vault-github-plugin-prod
Copy link

Package sonicwall_firewall - 1.19.0 containing this change is available at https://epr.elastic.co/package/sonicwall_firewall/1.19.0/

@elastic-vault-github-plugin-prod
Copy link

Package stormshield - 1.3.0 containing this change is available at https://epr.elastic.co/package/stormshield/1.3.0/

@elastic-vault-github-plugin-prod
Copy link

Package suricata - 2.25.0 containing this change is available at https://epr.elastic.co/package/suricata/2.25.0/

@Alphayeeeet Alphayeeeet deleted the remove-event.original4 branch July 14, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@gizas gizas gizas approved these changes

@nfritts nfritts nfritts approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees
No one assigned
Labels
Integration:fortinet_fortiedr Fortinet FortiEDR Logs Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Integration:fortinet_fortimanager Fortinet FortiManager Logs Integration:iptables Iptables Integration:istio Istio Integration:juniper_junos Juniper JunOS (Deprecated) Integration:juniper_netscreen Juniper NetScreen (Deprecated) Integration:juniper_srx Juniper SRX Integration:microsoft_dhcp Microsoft DHCP Integration:nagios_xi Nagios XI Integration:netscout Arbor Peakflow SP Logs (Deprecated) Integration:panw Palo Alto Next-Gen Firewall Integration:pfsense pfSense (Community supported) Integration:snort Snort Integration:sonicwall_firewall SonicWall Firewall Integration:stormshield StormShield SNS Integration:suricata Suricata Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Alphayeeeet @elasticmachine @andrewkroh @gizas @ishleenk17 @nfritts