-
Notifications
You must be signed in to change notification settings - Fork 474
[wiz] Add defend data stream #13688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wiz] Add defend data stream #13688
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
/test |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
cloud_configuration_finding |
6097.56 | 3424.66 | -2672.9 (-43.84%) | 💔 |
cloud_configuration_finding_full_posture |
11627.91 | 3731.34 | -7896.57 (-67.91%) | 💔 |
issue |
4672.9 | 2890.17 | -1782.73 (-38.15%) | 💔 |
vulnerability |
4237.29 | 2577.32 | -1659.97 (-39.18%) | 💔 |
To see the full report comment with /test benchmark fullreport
...l_posture/_dev/test/pipeline/test-cloud-configuration-finding-full-posture.log-expected.json
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/defend/agent/stream/http_endpoint.yml.hbs
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/defend/agent/stream/http_endpoint.yml.hbs
Outdated
Show resolved
Hide resolved
@@ -37,7 +37,7 @@ | |||
"id": "", | |||
"params": { | |||
"fontSize": 12, | |||
"markdown": "Navigation\n\n[Wiz Cloud Configuration Finding (This page)](#/dashboard/wiz-726802c0-4007-48b9-bae5-09daa69d4368)\n\n[Wiz Vulnerability](#/dashboard/wiz-927c36f0-6358-11ee-a265-c3569aa0cebf)\n\n[Wiz Issue](#/dashboard/wiz-d8f91a20-6363-11ee-a265-c3569aa0cebf)\n\n[Wiz Audit](#/dashboard/wiz-be3fd3f0-6358-11ee-9db4-21f79f2e6273)\n\n[Integration Page](/app/integrations/detail/wiz/overview)\n\nOverview\n\nThis dashboard shows the Cloud Configuration Findings overview related to the Wiz Integration.\n\nThis dashboard provides general statistics and shows the detection of ingested cloud configuration findings.\n\nIt provides information about findings and assets. It also displays the distribution of findings according to evaluation results and contains details regarding the count of findings over time.", | |||
"markdown": "Navigation\n\nWiz Cloud Configuration Finding\n\n[Wiz Vulnerability](#/dashboard/wiz-927c36f0-6358-11ee-a265-c3569aa0cebf)\n\n[Wiz Issue](#/dashboard/wiz-d8f91a20-6363-11ee-a265-c3569aa0cebf)\n\n[Wiz Defend](#/dashboard/wiz-3c3519be-f4f9-4c67-a9d8-1db4182b6e6a)\n\n[Wiz Audit](#/dashboard/wiz-be3fd3f0-6358-11ee-9db4-21f79f2e6273)\n\n[Integration Page](/app/integrations/detail/wiz/overview)\n\nOverview\n\nThis dashboard shows the Cloud Configuration Findings overview related to the Wiz Integration.\n\nThis dashboard provides general statistics and shows the detection of ingested cloud configuration findings.\n\nIt provides information about findings and assets. It also displays the distribution of findings according to evaluation results and contains details regarding the count of findings over time.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the order of the navigation list change for each of these pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have not changed any order here. As suggested in the earlier PRs, we have added all the missing dashboard links. Additionally, for the dashboard we are currently on, we have removed the "(This Page)" text and the link to it, as previously recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry, I should have been clearer. The order is the same as it was, but the previously existing order differs depending on which dashboard the user is on. I was wondering why that is the case. You may not know.
/test |
1. Revert the cloud_configuration test file changes. 2. Replace the resources stmt as suggested.
/test |
This looks good mod the conflicts that will need to be resolved. |
Conflicts don't appear to be correctly resolved. |
Resolved conflicts @efd6 |
/test |
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the commit message body for merging,
This adds a defend data stream for supporting detection events
forwarding via HTTP Endpoint and associated dashboards and
visualizations.
Wiz fields are mapped to their corresponding ECS fields where possible.
Test samples were derived from documentation and subsequently sanitized.
but I'd like to understand the last sentence. It says that the samples were obtained from documentation, so why were they sanitised?
The values were sanitized because some, such as IP addresses, were not private and needed to be mocked. |
Package wiz - 3.2.0 containing this change is available at https://epr.elastic.co/package/wiz/3.2.0/ |
Proposed commit message
This release includes a defend data stream for supporting detection events forwarding via HTTP Endpoint and associated dashboards and visualizations.
Wiz fields are mapped to their corresponding ECS fields where possible.
Test samples were derived from documentation.
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots